Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Resource naming conventions to follow standard #190

Closed
Coolomina opened this issue Sep 14, 2022 · 1 comment · Fixed by #192
Closed

docs: Resource naming conventions to follow standard #190

Coolomina opened this issue Sep 14, 2022 · 1 comment · Fixed by #192

Comments

@Coolomina
Copy link
Contributor

What is the improvement or update you wish to see?

While the provider is still relatively small, I think it would be great to standardise naming conventions across resource names.

Example of resource naming with no naming convention:

resource "checkly_check" "browser-check-1" {}
resource "checkly_alert_channel" "email_ac" {}

Example of resource naming with a naming convention:

resource "checkly_check" "browser_check_1" {}
resource "checkly_alert_channel" "email_ac" {}

You can find different resource name conventions in alert_channel and in environment variable, among others.

Is there any context that might help us understand?

A very well crafted guide on Terraform best practices is https://www.terraform-best-practices.com/naming, by Anton Babenko. I think it's relatively free to change the names in the examples.

Does the docs page already exist? Please link to it.

No response

@ianaya89
Copy link

@Coolomina thanks for your contribution. I think what you suggest will be a great addition. We will be executing this in the upcoming days.

@ianaya89 ianaya89 added this to the v1.6.* milestone Oct 19, 2022
@ianaya89 ianaya89 added this to Done in Maintenance Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Maintenance
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants