Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: updates authentication methods and renames resources #192

Merged
merged 3 commits into from
Oct 19, 2022
Merged

docs: updates authentication methods and renames resources #192

merged 3 commits into from
Oct 19, 2022

Conversation

Coolomina
Copy link
Contributor

@Coolomina Coolomina commented Sep 14, 2022 •
edited by ianaya89
Loading

Affected Components

  • Resources
  • Test
  • Docs
  • Tooling
  • Other

Pre-Requisites

  • Terraform code is formatted with terraform fmt
  • Go code is formatted with go fmt
  • plan & apply command of demo/main.tf file do not produce diffs

Notes for the Reviewer

Resolves #190
Resolves #191

@Coolomina
Copy link
Contributor Author

Ping @pilimartinez ? 👋🏻

@ianaya89 ianaya89 changed the title docs: Updates authentication methods and renames resources docs: updates authentication methods and renames resources Oct 18, 2022
@ianaya89
Copy link

@Coolomina sorry, we missed this. I was on parental leave and the team's bandwidth was significantly reduced. I
This is great; we are going to review it ASAP.

Thanks a lot!

@ianaya89 ianaya89 merged commit bb38d1a into checkly:main Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianaya89 ianaya89 ianaya89 approved these changes

@pilimartinez pilimartinez Awaiting requested review from pilimartinez pilimartinez is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: Describe alternative authentication method docs: Resource naming conventions to follow standard
2 participants
@Coolomina @ianaya89