Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/stability #226

Merged
merged 5 commits into from
Aug 4, 2023
Merged

Feature/stability #226

merged 5 commits into from
Aug 4, 2023

Conversation

nleach999
Copy link
Collaborator

Description

Resolves #225 - documents permissions needed for SAST service account to be able to retrieve scan stats

Stability improvements

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

InferCsharp win-x64 Results
/home/runner/work/CxAnalytix/CxAnalytix/Libs/CxAuditTrailsDB/DbAccess.cs:96: error: Dotnet Resource Leak
Leaked resource return of type CxAnalytix.CxAuditTrails.DB.DbAccess$FetchResults, Leaked resource con of type Microsoft.Data.SqlClient.SqlConnection in method "DbAccess$FetchResults DbAccess.FetchRecords(String,String,String,String,DateTime)".

/home/runner/work/CxAnalytix/CxAnalytix/Libs/CxRestClient/CxRestContextBase.cs:127: error: Dotnet Resource Leak
Leaked resource (output of System.Net.Http.FormUrlEncodedContent::.ctor() at Line 128) of type System.Net.Http.FormUrlEncodedContent in method "LoginToken CxRestContextBase.GetLoginToken(Dictionary`2<!0,!1>)".

/home/runner/work/CxAnalytix/CxAnalytix/Libs/CxRestClient/MNO/CxMnoPolicies.cs:28: error: Dotnet Resource Leak
Leaked resource reader of type Newtonsoft.Json.Linq.JTokenReader in method "String CxMnoPolicies.GetFlatPolicyNames(JToken)".

/home/runner/work/CxAnalytix/CxAnalytix/Libs/CxRestClient/SAST/CxSastGenerateScanReport.cs:32: error: Dotnet Resource Leak
Leaked resource reader of type Newtonsoft.Json.Linq.JTokenReader in method "String CxSastGenerateScanReport.ReadReportId(JToken)".

/home/runner/work/CxAnalytix/CxAnalytix/Libs/CxRestClient/SAST/CxSastScanReportGenStatus.cs:30: error: Dotnet Resource Leak
Leaked resource reader of type Newtonsoft.Json.Linq.JTokenReader in method "CxSastScanReportGenStatus$GenStatus CxSastScanReportGenStatus.ReadStatus(JToken)".

/home/runner/work/CxAnalytix/CxAnalytix/XForm/SastTransformer/Transformer.cs:996: error: Null Dereference
writeQueue could be null (last assigned on line 810) and is dereferenced.

/home/runner/work/CxAnalytix/CxAnalytix/XForm/SastTransformer/Transformer.cs:1011: error: Null Dereference
curPathNode could be null (last assigned on line 810) and is dereferenced.

Found 7 issues
Issue Type(ISSUED_TYPE_ID): #
Dotnet Resource Leak(DOTNET_RESOURCE_LEAK): 5
Null Dereference(NULLPTR_DEREFERENCE): 2

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

InferCsharp linux-x64 Results
/home/runner/work/CxAnalytix/CxAnalytix/Libs/CxAuditTrailsDB/DbAccess.cs:96: error: Dotnet Resource Leak
Leaked resource return of type CxAnalytix.CxAuditTrails.DB.DbAccess$FetchResults, Leaked resource con of type Microsoft.Data.SqlClient.SqlConnection in method "DbAccess$FetchResults DbAccess.FetchRecords(String,String,String,String,DateTime)".

/home/runner/work/CxAnalytix/CxAnalytix/Libs/CxRestClient/CxRestContextBase.cs:127: error: Dotnet Resource Leak
Leaked resource (output of System.Net.Http.FormUrlEncodedContent::.ctor() at Line 128) of type System.Net.Http.FormUrlEncodedContent in method "LoginToken CxRestContextBase.GetLoginToken(Dictionary`2<!0,!1>)".

/home/runner/work/CxAnalytix/CxAnalytix/Libs/CxRestClient/MNO/CxMnoPolicies.cs:28: error: Dotnet Resource Leak
Leaked resource reader of type Newtonsoft.Json.Linq.JTokenReader in method "String CxMnoPolicies.GetFlatPolicyNames(JToken)".

/home/runner/work/CxAnalytix/CxAnalytix/Libs/CxRestClient/SAST/CxSastGenerateScanReport.cs:32: error: Dotnet Resource Leak
Leaked resource reader of type Newtonsoft.Json.Linq.JTokenReader in method "String CxSastGenerateScanReport.ReadReportId(JToken)".

/home/runner/work/CxAnalytix/CxAnalytix/Libs/CxRestClient/SAST/CxSastScanReportGenStatus.cs:30: error: Dotnet Resource Leak
Leaked resource reader of type Newtonsoft.Json.Linq.JTokenReader in method "CxSastScanReportGenStatus$GenStatus CxSastScanReportGenStatus.ReadStatus(JToken)".

/home/runner/work/CxAnalytix/CxAnalytix/XForm/SastTransformer/Transformer.cs:996: error: Null Dereference
writeQueue could be null (last assigned on line 810) and is dereferenced.

/home/runner/work/CxAnalytix/CxAnalytix/XForm/SastTransformer/Transformer.cs:1011: error: Null Dereference
curPathNode could be null (last assigned on line 810) and is dereferenced.

Found 7 issues
Issue Type(ISSUED_TYPE_ID): #
Dotnet Resource Leak(DOTNET_RESOURCE_LEAK): 5
Null Dereference(NULLPTR_DEREFERENCE): 2

@nleach999 nleach999 merged commit 37e85fd into master Aug 4, 2023
17 checks passed
@nleach999 nleach999 deleted the feature/stability branch August 4, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional permissions required to retrieve SAST scan statistics
1 participant