Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEED] Integration Tests Rework #196

Closed
robin-checkmk opened this issue Dec 2, 2022 · 4 comments · Fixed by #323
Closed

[FEED] Integration Tests Rework #196

robin-checkmk opened this issue Dec 2, 2022 · 4 comments · Fixed by #323
Assignees
Labels
enhancement New feature or request feedback General feedback

Comments

@robin-checkmk
Copy link
Member

Provide your feedback

We currently have integration tests for:

  • Modules
  • The server role

For the agent role it was not possible to get something up and running in a reasonable amount of time.
All of the abovementioned integration tests show some level of flakiness. This is - as far as I can tell - related to installing Checkmk into container images not made for it. More specifically, a lot of issues point towards systemd.
In my current opinion we need full-fledged VMs to properly test all aspects of the collection. Obviously this is something we have to do on our own, but which is far from trivial.

So this issue is more of a note to everyone reading this, that the integration test are not in the best shape.
We try to keep them as useful as possible, without wasting too much time.

Component Name

  • All modules
  • All roles

Ansible Version

$ ansible --version

Collection Version

$ ansible-galaxy collection list

Environment

  • Local Docker
  • Github Actions

Screenshots

Additional context

@robin-checkmk robin-checkmk added enhancement New feature or request feedback General feedback labels Dec 2, 2022
@robin-checkmk robin-checkmk self-assigned this Dec 2, 2022
@robin-checkmk
Copy link
Member Author

Update: Current flakiness seems to be resolved for now. It might have been an update to the Ansible Testing Containers, but I cannot tell right now.

@github-actions
Copy link

This issue has been stale for 60 days. It will close in 7 days.

@github-actions github-actions bot added the stale Stale issues and pull requests. label Feb 21, 2023
@robin-checkmk robin-checkmk removed the stale Stale issues and pull requests. label Feb 21, 2023
@robin-checkmk robin-checkmk linked a pull request Apr 21, 2023 that will close this issue
7 tasks
@robin-checkmk
Copy link
Member Author

All flakiness is gone for some time now. So I will close this issue once #323 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feedback General feedback
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant