fix(converter): fix confusing error returning now rate

checkmoney · Mar 2, 2019 · 291f91e · 291f91e
1 parent b4ba88d
commit 291f91e
Showing 1 changed file with 5 additions and 8 deletions.
diff --git a/back/src/money/application/CurrencyConverter.ts b/back/src/money/application/CurrencyConverter.ts
@@ -77,16 +77,13 @@ export class CurrencyConverter {
   ): Promise<number> {
     const MIN_DAY_FOR_HISTORY_TRANSACTION = 2
 
-    const rateIsHistory =
+    const rateIsOld =
       differenceInDays(when, new Date()) > MIN_DAY_FOR_HISTORY_TRANSACTION
 
-    const getNowRate = () => this.exchangeRateApi.getExchangeRate(from, to)
-
-    const getHistoryRate = () =>
-      this.exchangeRateApi
-        .getHistoryExchangeRate(from, to, when)
-        .catch(getNowRate) // Okay, now rate is ok
+    if (rateIsOld) {
+      return this.exchangeRateApi.getHistoryExchangeRate(from, to, when)
+    }
 
-    return rateIsHistory ? getNowRate() : getHistoryRate()
+    return this.exchangeRateApi.getExchangeRate(from, to)
   }
 }