Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize find_unix_sk_by_ino() #339

Closed
xemul opened this issue Jun 29, 2017 · 0 comments · Fixed by #1020
Closed

Optimize find_unix_sk_by_ino() #339

xemul opened this issue Jun 29, 2017 · 0 comments · Fixed by #1020
Labels
enhancement

Comments

@xemul
Copy link
Member

xemul commented Jun 29, 2017

The routine in question does linear list search, but we may have many unix sockets in the dump. Turn it into a hash or tree.
ZeyadYasser added a commit to ZeyadYasser/criu that referenced this issue Apr 11, 2020
@ZeyadYasser
criu: fixes checkpoint-restore#339
4b54269 
Optimize find_unix_sk_by_ino().
Replaced the loop with a hashtable lookup.

Signed-off-by: ZeyadYasser <zeyady98@gmail.com>
ZeyadYasser added a commit to ZeyadYasser/criu that referenced this issue Apr 11, 2020
@ZeyadYasser
criu: fixes checkpoint-restore#339
e6bd52b 
Optimize find_unix_sk_by_ino().
Replaced the loop with a hashtable lookup.

Signed-off-by: ZeyadYasser <zeyady98@gmail.com>
ZeyadYasser added a commit to ZeyadYasser/criu that referenced this issue Apr 11, 2020
@ZeyadYasser
criu: fixes checkpoint-restore#339
2cb08e8 
Optimize find_unix_sk_by_ino().
Replaced the loop with a hashtable lookup.

Signed-off-by: ZeyadYasser <zeyady98@gmail.com>
ZeyadYasser added a commit to ZeyadYasser/criu that referenced this issue Apr 11, 2020
@ZeyadYasser
criu: optimize find_unix_sk_by_ino()
e86deb0 
Fixes: checkpoint-restore#339
Optimize find_unix_sk_by_ino().
Replaced the loop with a hashtable lookup.

Signed-off-by: ZeyadYasser <zeyady98@gmail.com>
@ZeyadYasser ZeyadYasser mentioned this issue Apr 11, 2020
Closed
ZeyadYasser added a commit to ZeyadYasser/criu that referenced this issue Apr 12, 2020
@ZeyadYasser
criu: optimize unix sockets lookup in restore
c077b9d 
Fixes: checkpoint-restore#339
Now (struct socket_table_entry) is the first memeber in (struct unix_sk_info).
So now it could be added to the sockets hashtable.
Replaced find_unix_sk_by_ino() with lookup_socket_ino().
This replaces the linear search with a hashtable lookup.

Signed-off-by: ZeyadYasser <zeyady98@gmail.com>
@ZeyadYasser ZeyadYasser mentioned this issue Apr 12, 2020
Merged
ZeyadYasser added a commit to ZeyadYasser/criu that referenced this issue Apr 13, 2020
@ZeyadYasser
criu: optimize unix sockets lookup in restore
7ed0f9b 
Fixes: checkpoint-restore#339
Now (struct socket_table_entry) is the first memeber in (struct unix_sk_info).
So now it could be added to the sockets hashtable.
Replaced find_unix_sk_by_ino() with lookup_socket_ino().
This replaces the linear search with a hashtable lookup.

Signed-off-by: Zeyad Yasser <zeyady98@gmail.com>
ZeyadYasser added a commit to ZeyadYasser/criu that referenced this issue Apr 15, 2020
@ZeyadYasser
criu: optimize find_unix_sk_by_ino()
6285ff2 
Fixes: checkpoint-restore#339
Replaced the linear search with a hashtable lookup.

Signed-off-by: Zeyad Yasser <zeyady98@gmail.com>
ZeyadYasser added a commit to ZeyadYasser/criu that referenced this issue Apr 16, 2020
@ZeyadYasser
criu: optimize find_unix_sk_by_ino()
e3ac548 
Fixes: checkpoint-restore#339
Replaced the linear search with a hashtable lookup.

Signed-off-by: Zeyad Yasser <zeyady98@gmail.com>
ZeyadYasser added a commit to ZeyadYasser/criu that referenced this issue May 7, 2020
@ZeyadYasser
criu: optimize find_unix_sk_by_ino()
d27c0ef 
Fixes: checkpoint-restore#339
Replaced the linear search with a hashtable lookup.

Signed-off-by: Zeyad Yasser <zeyady98@gmail.com>
avagin pushed a commit that referenced this issue May 31, 2020
@ZeyadYasser @avagin
criu: optimize find_unix_sk_by_ino()
6a2e2c1 
Fixes: #339
Replaced the linear search with a hashtable lookup.

Signed-off-by: Zeyad Yasser <zeyady98@gmail.com>
avagin pushed a commit to avagin/criu that referenced this issue Jun 9, 2020
@ZeyadYasser @avagin
criu: optimize find_unix_sk_by_ino()
53fe42a 
Fixes: checkpoint-restore#339
Replaced the linear search with a hashtable lookup.

Signed-off-by: Zeyad Yasser <zeyady98@gmail.com>
angieenee pushed a commit to angieenee/criu that referenced this issue Jun 12, 2020
@ZeyadYasser
criu: optimize find_unix_sk_by_ino()
e687561 
Fixes: checkpoint-restore#339
Replaced the linear search with a hashtable lookup.

Signed-off-by: Zeyad Yasser <zeyady98@gmail.com>
avagin pushed a commit to avagin/criu that referenced this issue Jul 15, 2020
@ZeyadYasser @avagin
criu: optimize find_unix_sk_by_ino()
c15eb88 
Fixes: checkpoint-restore#339
Replaced the linear search with a hashtable lookup.

Signed-off-by: Zeyad Yasser <zeyady98@gmail.com>
avagin pushed a commit to avagin/criu that referenced this issue Jul 16, 2020
@ZeyadYasser @avagin
criu: optimize find_unix_sk_by_ino()
0d81417 
Fixes: checkpoint-restore#339
Replaced the linear search with a hashtable lookup.

Signed-off-by: Zeyad Yasser <zeyady98@gmail.com>
avagin pushed a commit to avagin/criu that referenced this issue Oct 1, 2020
@ZeyadYasser @avagin
criu: optimize find_unix_sk_by_ino()
ee9365f 
Fixes: checkpoint-restore#339
Replaced the linear search with a hashtable lookup.

Signed-off-by: Zeyad Yasser <zeyady98@gmail.com>
avagin pushed a commit that referenced this issue Oct 20, 2020
@ZeyadYasser @avagin
criu: optimize find_unix_sk_by_ino()
e57e74a 
Fixes: #339
Replaced the linear search with a hashtable lookup.

Signed-off-by: Zeyad Yasser <zeyady98@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Optimize find_unix_sk_by_ino() ZeyadYasser/criu
Optimize find_unix_sk_by_ino() ZeyadYasser/criu
1 participant
@xemul