Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipes: Plug pipe fd leak in "Unable to set a pipe size" error case. #2208

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

osctobe
Copy link
Contributor

@osctobe osctobe commented Jun 21, 2023

A trivial fix for error path leaking pipe fds.

@mihalicyn
Copy link
Member

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.06 ⚠️

Comparison is base (f018893) 70.61% compared to head (18c405c) 70.55%.

❗ Current head 18c405c differs from pull request most recent head 6bcadb7. Consider uploading reports for the commit 6bcadb7 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           criu-dev    #2208      +/-   ##
============================================
- Coverage     70.61%   70.55%   -0.06%     
============================================
  Files           133      133              
  Lines         33243    33502     +259     
============================================
+ Hits          23473    23636     +163     
- Misses         9770     9866      +96     
Impacted Files Coverage Δ
criu/pipes.c 82.44% <0.00%> (ø)

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

From: Piotr Figiel <figiel@google.com>
Signed-off-by: Michał Mirosław <emmir@google.com>
@avagin avagin merged commit 12290f4 into checkpoint-restore:criu-dev Jun 22, 2023
29 of 38 checks passed
@osctobe osctobe deleted the bad-leaking-pipes branch June 22, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants