Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: return bool with iptable_has_criu_jump_target #2337

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

rst0git
Copy link
Member

@rst0git rst0git commented Jan 23, 2024

To improve readability, this pull request changes the return type of iptables_has_criu_jump_target() to a boolean, where true indicates that iptables has CRIU jump target and false indicates otherwise.

Suggested-by: Pavel Tikhomirov ptikhomirov@virtuozzo.com

To improve readability, this patch changes the return type of
iptables_has_criu_jump_target() to a boolean, where 'true' indicates
that iptables has CRIU jump target and 'false' indicates otherwise.

Suggested-by: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dfd7d63) 70.57% compared to head (86e0203) 70.57%.

❗ Current head 86e0203 differs from pull request most recent head 110657d. Consider uploading reports for the commit 110657d to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##           criu-dev    #2337   +/-   ##
=========================================
  Coverage     70.57%   70.57%           
=========================================
  Files           132      132           
  Lines         33619    33619           
=========================================
  Hits          23726    23726           
  Misses         9893     9893           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Snorch
Copy link
Member

Snorch commented Jan 23, 2024

Looks good, thank you!

@avagin avagin merged commit 07a090b into checkpoint-restore:criu-dev Jan 25, 2024
39 checks passed
@rst0git rst0git deleted the net-return branch January 25, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants