-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pagemap-cache: handle short reads #2411
pagemap-cache: handle short reads #2411
Conversation
472a662
to
f5789e3
Compare
f5789e3
to
c1c50de
Compare
e7043b0
to
6737b5e
Compare
Is this error expected? |
Overall, it looks good to me. Thanks. |
It is possible for pread() to return fewer number of bytes than requested. In such case, we need to repeat the read operation with appropriate offset. Signed-off-by: Andrei Vagin <avagin@gmail.com> Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
This commit adds a `--preload-libfault` option to ZDTM's run command. This option runs CRIU with LD_PRELOAD to intercept libc functions such as pread(). This method allows to simulate special cases, for example, when a successful call to pread() transfers fewer bytes than requested. Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
6737b5e
to
1e07c20
Compare
I was able to replicate this error on Ubuntu but not in Fedora. It looks like the reason for the error is because the repository is under |
It is possible for
pread()
to return fewer number of bytes than requested. In such case, we need to repeat the read operation with appropriate offset.Fixes: #2365