Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add stylecheck to golangci-lint #128

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

snprajwal
Copy link
Member

Fixes #127

Signed-off-by: Prajwal S N <prajwalnadig21@gmail.com>
Signed-off-by: Prajwal S N <prajwalnadig21@gmail.com>
@snprajwal
Copy link
Member Author

PTAL @adrianreber

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Patch coverage: 50.00% and no project coverage change.

Comparison is base (bdafabc) 22.74% compared to head (6099c56) 22.74%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #128   +/-   ##
=======================================
  Coverage   22.74%   22.74%           
=======================================
  Files          95       95           
  Lines       15292    15292           
=======================================
  Hits         3478     3478           
  Misses      11514    11514           
  Partials      300      300           
Impacted Files Coverage Δ
crit/decode-extra.go 0.00% <0.00%> (ø)
crit/decode.go 28.66% <0.00%> (ø)
crit/encode-extra.go 0.00% <0.00%> (ø)
crit/encode.go 19.16% <0.00%> (ø)
crit/utils.go 25.49% <33.33%> (ø)
crit/image.go 44.79% <50.00%> (ø)
crit/explore.go 70.16% <71.42%> (ø)
test/crit/main.go 66.23% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adrianreber
Copy link
Member

Thanks.

Although most changes are done to internal functions this technically means this might break API. I am not aware of any external user of crit so far, so not sure if we need to increase the version to v7 for go-criu or not. I think PsTree might be the only structure which would count as API change. I think we do not need v7, but maybe we need it anyway at some point in the future. Just wanted to mention it here.

@snprajwal
Copy link
Member Author

We will definitely need v0.7.0 once we merge #109, so I think we can merge this and release it with that change

@adrianreber adrianreber merged commit 6b54af8 into checkpoint-restore:master Apr 26, 2023
14 checks passed
@snprajwal snprajwal deleted the add-stylecheck branch May 13, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable 'stylecheck' golangci-lint linter
2 participants