Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enable tests with go 1.19.x #82

Merged
merged 2 commits into from
Aug 30, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
strategy:
fail-fast: false
matrix:
go-version: [1.17.x, 1.18.x]
go-version: [1.17.x, 1.18.x, 1.19.x]
# criu is pre-installed in the Ubuntu 20.04 GitHub Action virtual
# environment as a dependency for Podman
criu_branch: ["", criu-dev]
Expand Down
24 changes: 12 additions & 12 deletions phaul/api.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,19 +27,19 @@ type Remote interface {
// Local interface
// Interface to local classes. Client calls them when it needs something on the source node.
//
//Methods:
// Methods:
//
// - DumpCopyRestore() is called on client side when the
// pre-iterations are over and it's time to do full dump,
// copy images and restore them on the server side.
// All the time this method is executed victim tree is
// frozen on client. Returning nil kills the tree, error
// unfreezes it and resumes. The criu argument is the
// pointer on created criu.Criu object on which client
// may call Dump(). The requirement on opts passed are:
// set Ps.Fd to comm.Memfd
// set ParentImg to lastClientImagesPath
// set TrackMem to true
// - DumpCopyRestore() is called on client side when the
// pre-iterations are over and it's time to do full dump,
// copy images and restore them on the server side.
// All the time this method is executed victim tree is
// frozen on client. Returning nil kills the tree, error
// unfreezes it and resumes. The criu argument is the
// pointer on created criu.Criu object on which client
// may call Dump(). The requirement on opts passed are:
// set Ps.Fd to comm.Memfd
// set ParentImg to lastClientImagesPath
// set TrackMem to true
type Local interface {
DumpCopyRestore(criu *criu.Criu, c Config, lastClientImagesPath string) error
}
1 change: 0 additions & 1 deletion phaul/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ func MakePhaulServer(c Config) (*Server, error) {
return &Server{imgs: img, cfg: c, cr: cr}, nil
}

//
// StartIter phaul.Remote methods
func (s *Server) StartIter() error {
fmt.Printf("S: start iter\n")
Expand Down
1 change: 0 additions & 1 deletion rpc/rpc.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions test/main_coverage_test.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
//go:build coverage
// +build coverage

package main
Expand Down