Allow passing API key in individual calls #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veechau
force-pushed
the
ronan-veronica/add-optional-api-key-param-for-requests
branch
from
76f3448
to
13afc09
Compare
veechau
force-pushed
the
ronan-veronica/add-optional-api-key-param-for-requests
branch
from
13afc09
to
4c15e30
Compare
erdey
reviewed
Dec 3, 2018
| @@ -61,6 +61,8 @@ def self.api_url(path='') | |||
| end | |||
|
|
|||
| def self.request(method, path, params={}, headers={}) | |||
| api_key = headers.key?(:api_key) ? headers.delete(:api_key) : @api_key | |||
There was a problem hiding this comment.
I'd recommend to set this as different param
There was a problem hiding this comment.
Sorry I caused confusion with the usage of 'param' here. Ideally I wanted to see it in another argument. Given complexity for this, and that's it's been implemented like this (using headers) in other public gem, I'm ok with it.
|
Closing due to #53 |
veechau
deleted the
ronan-veronica/add-optional-api-key-param-for-requests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow passing of API for individual calls in order to allow for thread safe usage of multiple API keys.