bugfix: + takes precedence over ternary operator

[xiaoronglv]

Problem

when the base URL contains parameters, the params argument will be ignored.

How to reproduce?

URL: https://api.checkr-staging.com/v1/nodes?include=packages
parameter: {page: 2}

Root cause

Ruby operator + takes precedence over ? :, when URI.parse returns true, only & will be returned.

 url += URI.parse(url).query ? '&' : '?' + Util.query_string(params)

Here is the execution plan

 url += if URI.parse(url).query 
  '&' 
 else
'?' + Util.query_string(params)

How to fix it?

solution 1: use the parenthesis to correct the precedence.

 url += (URI.parse(url).query ? '&' : '?') + Util.query_string(params)

solution2: change the code to two lines.

Changes

in this PR, we use solution2 to fix the bug.

[akshay-8d66]

Thanks for this fix!