adding Service Spec editor for admin/settings #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffrey
reviewed
Jul 18, 2017
| [CALL_API]: { | ||
| endpoint: `${API_ROOT}/admin/serviceSpecs`, | ||
| method: 'GET', | ||
| headers: { |
There was a problem hiding this comment.
nit: seems like headers are the same for all API calls here we could extract in a function to DRY it up
There was a problem hiding this comment.
I tried to do this, but failed... Not sure how to pass this around in this special formatting here...
geoffrey
reviewed
Jul 18, 2017
|
|
||
| export default connect( state => { | ||
| const formValues = state.form.serviceSpec | ||
| return { formValues: formValues } |
geoffrey
reviewed
Jul 18, 2017
|
|
||
| componentWillMount() { | ||
| this.props.fetchServiceSpecSettings() | ||
|
|
geoffrey
reviewed
Jul 18, 2017
| <li className="list-group-item" key={specSetting._id}> | ||
| <div className="feed-element"> | ||
| <div className="media-body"> | ||
| <ServiceSpecForm initialValues={specSetting} edit={specSetting.edit} onSubmit={this.onSaveSpec} onCancel={ () => this.onCancel()} onDelete={this.onDeleteSpec}/> |
There was a problem hiding this comment.
nit: any reason you don't have onCancel={ this.onCancel } ?
There was a problem hiding this comment.
cause it needs to bind to this. the alternative might be to bind it in the constructor like some of the onSave type stuff
jeremyd
force-pushed
the
servicespec
branch
2 times, most recently
from
34e5de8
to
aba1f46
Compare
geoffrey
approved these changes
Jul 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.