add support for querying flags by description, enabled and with limit #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouzhuojie
reviewed
Jun 6, 2018
pkg/handler/crud.go
Outdated
| @@ -68,6 +70,34 @@ var ( | |||
| func (c *crud) FindFlags(params flag.FindFlagsParams) middleware.Responder { | |||
| fs := []entity.Flag{} | |||
| q := entity.NewFlagQuerySet(getDB()) | |||
| queryParams := map[string]string{ | |||
There was a problem hiding this comment.
I think it's better to put the query params in swagger query params.
https://github.com/checkr/flagr/blob/master/swagger/flags.yaml#L1
For example, https://swagger.io/docs/specification/describing-parameters/#query-parameters
After the change of the swagger definitions, run make gen to get the latest swagger model. We can get type safety and API doc for free in this case.
|
@zhouzhuojie I have updated the pr to use swagger.yml for query param validation |
|
Awesome work @amalfra 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for querying flags by description and enabled status; also adds support for limiting number of results returned using limit query parameter
Motivation and Context
#100 - the flags endpoint currently does not support filtering and limiting results. this seems to be useful feature for clients consuming the API.
How Has This Been Tested?
Types of changes
Checklist: