Add integration tests #190
Conversation
zhouzhuojie
force-pushed
the
zz/add-integration-test
branch
from
7bf58b7
to
145a46b
Compare
Codecov Report
@@ Coverage Diff @@
## master #190 +/- ##
==========================================
- Coverage 90.85% 90.83% -0.02%
==========================================
Files 25 25
Lines 1410 1408 -2
==========================================
- Hits 1281 1279 -2
Misses 96 96
Partials 33 33
Continue to review full report at Codecov.
|
zhouzhuojie
force-pushed
the
zz/add-integration-test
branch
2 times, most recently
from
e3b49ad
to
930eccb
Compare
zhouzhuojie
force-pushed
the
zz/add-integration-test
branch
from
930eccb
to
956d52f
Compare
| @@ -986,7 +986,6 @@ definitions: | |||
| type: object | |||
| required: | |||
| - key | |||
| - attachment | |||
There was a problem hiding this comment.
no need to be required, tested with integration tests
| @@ -1060,9 +1059,6 @@ definitions: | |||
| format: int64 | |||
| minimum: 0 | |||
| maximum: 100 | |||
| bitmap: | |||
There was a problem hiding this comment.
not needed now, tested with integration tests
| @@ -89,7 +89,7 @@ func (c *crud) FindFlags(params flag.FindFlagsParams) middleware.Responder { | |||
| q = q.Offset(int(*params.Offset)) | |||
| } | |||
|
|
|||
| err := q.All(&fs) | |||
| err := q.OrderAscByID().All(&fs) | |||
There was a problem hiding this comment.
Need to explicitly sort by ID for postgres, caught by integration tests
| @@ -213,7 +213,7 @@ var evalSegment = func( | |||
| Msg: fmt.Sprintf("constraints are present in the segment_id %v, but got invalid entity_context: %s.", segment.ID, spew.Sdump(evalContext.EntityContext)), | |||
| SegmentID: int64(segment.ID), | |||
| } | |||
| return nil, log, false | |||
| return nil, log, true | |||
There was a problem hiding this comment.
Caught by integration tests. We need to continue if evalContext.EntityContext if nil or invalid, because there may be some segments below that has no constraints.
Description
Add integration tests so that we can test flagr against multiple environments or multiple DBs.
Motivation and Context
To cover DB discrepancies.
How Has This Been Tested?
Will add more endpoints covered by the swagger API definition.
Types of changes
Checklist: