Issue #13213: Remove '//ok' comments from Input files

checkstyle · Apr 2, 2024 · 69f2e98 · 69f2e98
1 parent b39a48b
commit 69f2e98
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 51 deletions.
diff --git a/config/checkstyle-input-suppressions.xml b/config/checkstyle-input-suppressions.xml
@@ -431,40 +431,6 @@
             files="checks[\\/]javadoc[\\/]javadocmethod[\\/]InputJavadocMethodScopeInnerInterfaces.java"/>
   <suppress id="UnnecessaryOkComment"
             files="checks[\\/]javadoc[\\/]javadocmethod[\\/]InputJavadocMethodScopeInnerInterfaces.java"/>
-  <suppress id="UnnecessaryOkComment"
-            files="checks[\\/]javadoc[\\/]javadocmethod[\\/]InputJavadocMethodSetterGetter.java"/>
-  <suppress id="UnnecessaryOkComment"
-            files="checks[\\/]javadoc[\\/]javadocmethod[\\/]InputJavadocMethodSetterGetter.java"/>
-  <suppress id="UnnecessaryOkComment"
-            files="checks[\\/]javadoc[\\/]javadocmethod[\\/]InputJavadocMethodSetterGetter.java"/>
-  <suppress id="UnnecessaryOkComment"
-            files="checks[\\/]javadoc[\\/]javadocmethod[\\/]InputJavadocMethodSetterGetter.java"/>
-  <suppress id="UnnecessaryOkComment"
-            files="checks[\\/]javadoc[\\/]javadocmethod[\\/]InputJavadocMethodSetterGetter.java"/>
-  <suppress id="UnnecessaryOkComment"
-            files="checks[\\/]javadoc[\\/]javadocmethod[\\/]InputJavadocMethodSetterGetter.java"/>
-  <suppress id="UnnecessaryOkComment"
-            files="checks[\\/]javadoc[\\/]javadocmethod[\\/]InputJavadocMethodSetterGetter.java"/>
-  <suppress id="UnnecessaryOkComment"
-            files="checks[\\/]javadoc[\\/]javadocmethod[\\/]InputJavadocMethodSetterGetter.java"/>
-  <suppress id="UnnecessaryOkComment"
-            files="checks[\\/]javadoc[\\/]javadocmethod[\\/]InputJavadocMethodSetterGetter.java"/>
-  <suppress id="UnnecessaryOkComment"
-            files="checks[\\/]javadoc[\\/]javadocmethod[\\/]InputJavadocMethodSetterGetter.java"/>
-  <suppress id="UnnecessaryOkComment"
-            files="checks[\\/]javadoc[\\/]javadocmethod[\\/]InputJavadocMethodSetterGetter.java"/>
-  <suppress id="UnnecessaryOkComment"
-            files="checks[\\/]javadoc[\\/]javadocmethod[\\/]InputJavadocMethodSetterGetter.java"/>
-  <suppress id="UnnecessaryOkComment"
-            files="checks[\\/]javadoc[\\/]javadocmethod[\\/]InputJavadocMethodSetterGetter.java"/>
-  <suppress id="UnnecessaryOkComment"
-            files="checks[\\/]javadoc[\\/]javadocmethod[\\/]InputJavadocMethodSetterGetter.java"/>
-  <suppress id="UnnecessaryOkComment"
-            files="checks[\\/]javadoc[\\/]javadocmethod[\\/]InputJavadocMethodSetterGetter.java"/>
-  <suppress id="UnnecessaryOkComment"
-            files="checks[\\/]javadoc[\\/]javadocmethod[\\/]InputJavadocMethodSetterGetter.java"/>
-  <suppress id="UnnecessaryOkComment"
-            files="checks[\\/]javadoc[\\/]javadocmethod[\\/]InputJavadocMethodSetterGetter.java"/>
   <suppress id="UnnecessaryOkComment"
             files="checks[\\/]javadoc[\\/]javadocmethod[\\/]InputJavadocMethodSurroundingAccessModifier.java"/>
   <suppress id="UnnecessaryOkComment"

diff --git a/...pycrawl/tools/checkstyle/checks/javadoc/javadocmethod/InputJavadocMethodSetterGetter.java b/...pycrawl/tools/checkstyle/checks/javadoc/javadocmethod/InputJavadocMethodSetterGetter.java
@@ -14,75 +14,75 @@
 
 public class InputJavadocMethodSetterGetter
 {
-    private int mNumber; // ok
+    private int mNumber;
 
-    public void setNumber(final int number) // ok
+    public void setNumber(final int number)
     {
         mNumber = number;
     }
 
-    public int getNumber() // ok
+    public int getNumber()
     {
         return mNumber;
     }
 
-    public void setNumber1() // ok
+    public void setNumber1()
     {
         mNumber = mNumber;
     }
 
-    public void setNumber2(int number) // ok
+    public void setNumber2(int number)
     {
         mNumber = number;
         firePropertyChanged();
     }
 
-    public void getNumber2() // ok
+    public void getNumber2()
     {
     }
 
-    public int getCost1(int forMe) // ok
+    public int getCost1(int forMe)
     {
         return 666;
     }
 
-    public int getCost2() // ok
+    public int getCost2()
     {
             mNumber = 4;
         return 666;
     }
 
-    public int getCost3() throws Exception // ok
+    public int getCost3() throws Exception
     {
         return 666;
     }
 
-    public boolean isSomething() // ok
+    public boolean isSomething()
     {
         return false;
     }
 
-    private void firePropertyChanged(){} // ok
+    private void firePropertyChanged(){}
 
-    Object setObject(Object object) { // ok
+    Object setObject(Object object) {
         return new Object();
     }
 
-    Object getNext() { // ok
+    Object getNext() {
         throw new UnsupportedOperationException();
     }
 
-    public void setWithoutAssignment(Object object) { // ok
+    public void setWithoutAssignment(Object object) {
         object.notify();
     }
 
-    InputJavadocMethodSetterGetter() {} // ok
+    InputJavadocMethodSetterGetter() {}
 
-    public InputJavadocMethodSetterGetter(Object object) throws Exception {} // ok
+    public InputJavadocMethodSetterGetter(Object object) throws Exception {}
 
 }
 
-interface TestInterface { // ok
+interface TestInterface {
     void setObject(Object object);
 
     Object getObject();