minor: fix some sonar and IDEA warnings

checkstyle · May 13, 2019 · 6f5257e · 6f5257e
1 parent 142b67b
commit 6f5257e
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 20 deletions.
diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/XmlLoader.java b/src/main/java/com/puppycrawl/tools/checkstyle/XmlLoader.java
@@ -141,7 +141,7 @@ private LoadExternalDtdFeatureProvider() {
         public static void setFeaturesBySystemProperty(SAXParserFactory factory)
                 throws SAXException, ParserConfigurationException {
 
-            final boolean enableExternalDtdLoad = Boolean.valueOf(
+            final boolean enableExternalDtdLoad = Boolean.parseBoolean(
                 System.getProperty(ENABLE_EXTERNAL_DTD_LOAD, "false"));
 
             factory.setFeature(LOAD_EXTERNAL_DTD, enableExternalDtdLoad);

diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/TranslationCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/TranslationCheck.java
@@ -260,10 +260,8 @@ public void finishProcessing() {
      * @param bundle resource bundle.
      */
     private void checkExistenceOfDefaultTranslation(ResourceBundle bundle) {
-        final Optional<String> fileName = getMissingFileName(bundle, null);
-        if (fileName.isPresent()) {
-            logMissingTranslation(bundle.getPath(), fileName.get());
-        }
+        getMissingFileName(bundle, null)
+            .ifPresent(fileName -> logMissingTranslation(bundle.getPath(), fileName));
     }
 
     /**
@@ -275,10 +273,8 @@ private void checkExistenceOfDefaultTranslation(ResourceBundle bundle) {
      */
     private void checkExistenceOfRequiredTranslations(ResourceBundle bundle) {
         for (String languageCode : requiredTranslations) {
-            final Optional<String> fileName = getMissingFileName(bundle, languageCode);
-            if (fileName.isPresent()) {
-                logMissingTranslation(bundle.getPath(), fileName.get());
-            }
+            getMissingFileName(bundle, languageCode)
+                .ifPresent(fileName -> logMissingTranslation(bundle.getPath(), fileName));
         }
     }
 

diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/MultipleStringLiteralsCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/MultipleStringLiteralsCheck.java
@@ -188,12 +188,7 @@ public void visitToken(DetailAST ast) {
         if (!isInIgnoreOccurrenceContext(ast)) {
             final String currentString = ast.getText();
             if (ignoreStringsRegexp == null || !ignoreStringsRegexp.matcher(currentString).find()) {
-                List<DetailAST> hitList = stringMap.get(currentString);
-                if (hitList == null) {
-                    hitList = new ArrayList<>();
-                    stringMap.put(currentString, hitList);
-                }
-                hitList.add(ast);
+                stringMap.computeIfAbsent(currentString, key -> new ArrayList<>()).add(ast);
             }
         }
     }

diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/AbstractJavadocCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/AbstractJavadocCheck.java
@@ -272,11 +272,6 @@ public final void beginTree(DetailAST rootAST) {
         TREE_CACHE.get().clear();
     }
 
-    @Override
-    public final void finishTree(DetailAST rootAST) {
-        // No code by default
-    }
-
     @Override
     public final void visitToken(DetailAST blockCommentNode) {
         if (JavadocUtil.isJavadocComment(blockCommentNode)) {