Skip to content

Commit

Permalink
Issue #13213: Remove '//ok' from atclauseorder
Browse files Browse the repository at this point in the history
  • Loading branch information
OmarShawky1 authored and romani committed Mar 9, 2024
1 parent e481d61 commit 75f3200
Show file tree
Hide file tree
Showing 8 changed files with 6 additions and 21 deletions.
14 changes: 0 additions & 14 deletions config/checkstyle-input-suppressions.xml
Expand Up @@ -237,20 +237,6 @@
files="checks[\\/]javadoc[\\/]abstractjavadoc[\\/]InputAbstractJavadocPositionOnlyComments.java"/>
<suppress id="UnnecessaryOkComment"
files="checks[\\/]javadoc[\\/]abstractjavadoc[\\/]InputAbstractJavadocTokensPass.java"/>
<suppress id="UnnecessaryOkComment"
files="checks[\\/]javadoc[\\/]atclauseorder[\\/]InputAtclauseOrder1.java"/>
<suppress id="UnnecessaryOkComment"
files="checks[\\/]javadoc[\\/]atclauseorder[\\/]InputAtclauseOrderCorrect1.java"/>
<suppress id="UnnecessaryOkComment"
files="checks[\\/]javadoc[\\/]atclauseorder[\\/]InputAtclauseOrderCorrect2.java"/>
<suppress id="UnnecessaryOkComment"
files="checks[\\/]javadoc[\\/]atclauseorder[\\/]InputAtclauseOrderCorrect3.java"/>
<suppress id="UnnecessaryOkComment"
files="checks[\\/]javadoc[\\/]atclauseorder[\\/]InputAtclauseOrderCorrect4.java"/>
<suppress id="UnnecessaryOkComment"
files="checks[\\/]javadoc[\\/]atclauseorder[\\/]InputAtclauseOrderIncorrect4.java"/>
<suppress id="UnnecessaryOkComment"
files="checks[\\/]javadoc[\\/]atclauseorder[\\/]InputAtclauseOrderIncorrectCustom1.java"/>
<suppress id="UnnecessaryOkComment"
files="checks[\\/]javadoc[\\/]javadocblocktaglocation[\\/]InputJavadocBlockTagLocationCorrect.java"/>
<suppress id="UnnecessaryOkComment"
Expand Down
Expand Up @@ -11,7 +11,6 @@

package com.puppycrawl.tools.checkstyle.checks.javadoc.atclauseorder;

// ok
/**
* Some javadoc.
*
Expand Down
Expand Up @@ -20,7 +20,7 @@
* @version 1.0
* @see Some javadoc.
* @since Some javadoc.
* @deprecated Some javadoc. // ok
* @deprecated Some javadoc.
*/
class InputAtclauseOrderCorrect1 implements Serializable
{
Expand Down
Expand Up @@ -30,7 +30,7 @@ class InnerClassWithAnnotations2
* @throws Exception Some text.
* @deprecated Some text.
*/
String method(String aString) throws Exception { // ok
String method(String aString) throws Exception {
return "null";
}

Expand Down
Expand Up @@ -26,7 +26,7 @@ class InnerClassWithAnnotations3 {
* @throws Exception Some text.
* @deprecated Some text.
*/
void method3() throws Exception { // ok
void method3() throws Exception {
}

/**
Expand Down
Expand Up @@ -30,7 +30,7 @@ class InnerClassWithAnnotations4 {
* @serialData Some javadoc.
* @deprecated Some text.
*/
String method5(String aString) { // ok
String method5(String aString) {
return "null";
}

Expand Down
Expand Up @@ -39,7 +39,7 @@ class InnerClassWithAnnotations4 {
* @deprecated Some text.
* @return Some text. // violation
*/
String method5(String aString) { // ok
String method5(String aString) {
return "null";
}

Expand Down
Expand Up @@ -49,7 +49,7 @@ class InputAtclauseOrderIncorrectCustom1 implements Serializable
* @deprecated Some text.
* @throws Exception Some text.
*/
String method(String aString) throws Exception { // ok
String method(String aString) throws Exception {
return "null";
}

Expand Down

0 comments on commit 75f3200

Please sign in to comment.