Issue #4727: fixed FinalLocalVariable scanning anonymous classes

checkstyle · Jul 30, 2017 · 8fef906 · 8fef906
1 parent e77e2c8
commit 8fef906
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 1 deletion.
diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/FinalLocalVariableCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/FinalLocalVariableCheck.java
@@ -210,7 +210,8 @@ public void visitToken(DetailAST ast) {
                 break;
             case TokenTypes.VARIABLE_DEF:
                 if (ast.getParent().getType() != TokenTypes.OBJBLOCK
-                        && !ast.branchContains(TokenTypes.FINAL)
+                        && ast.findFirstToken(TokenTypes.MODIFIERS)
+                            .findFirstToken(TokenTypes.FINAL) == null
                         && !isVariableInForInit(ast)
                         && shouldCheckEnhancedForLoopVariable(ast)) {
                     insertVariable(ast);

diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/FinalLocalVariableCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/FinalLocalVariableCheckTest.java
@@ -254,4 +254,13 @@ public void testBreakOrReturn() throws Exception {
         };
         verify(checkConfig, getPath("InputFinalLocalVariableBreak.java"), expected);
     }
+
+    @Test
+    public void testAnonymousClass() throws Exception {
+        final DefaultConfiguration checkConfig = createModuleConfig(FinalLocalVariableCheck.class);
+        final String[] expected = {
+            "5:16: " + getCheckMessage(MSG_KEY, "testSupport"),
+        };
+        verify(checkConfig, getPath("InputFinalLocalVariableAnonymousClass.java"), expected);
+    }
 }
diff --git a/...ls/checkstyle/checks/coding/finallocalvariable/InputFinalLocalVariableAnonymousClass.java b/...ls/checkstyle/checks/coding/finallocalvariable/InputFinalLocalVariableAnonymousClass.java
@@ -0,0 +1,14 @@
+package com.puppycrawl.tools.checkstyle.checks.coding.finallocalvariable;
+
+public class InputFinalLocalVariableAnonymousClass {
+    public void test() {
+        Object testSupport = new Object() {
+            @Override
+            public String toString() {
+                final String dc = new String();
+                return dc;
+            }
+        };
+        testSupport.toString();
+    }
+}