Issue #14448: Migrated IDEA to highest true scopes release v2022.3.3

checkstyle · Apr 17, 2024 · d37b821 · d37b821
1 parent 0707dd5
commit d37b821
Show file tree

Hide file tree

Showing 30 changed files with 141 additions and 4 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -4,7 +4,7 @@ jobs:
 
   run-inspections:
     docker:
-      - image: checkstyle/idea-docker:jdk11-idea2022.2.2
+      - image: checkstyle/idea-docker:jdk11-idea2022.3.3
 
     steps:
       - checkout

diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/ant/CheckstyleAntTask.java b/src/main/java/com/puppycrawl/tools/checkstyle/ant/CheckstyleAntTask.java
@@ -449,6 +449,8 @@ private Properties createOverridingProperties() {
      *
      * @return the list of listeners.
      * @throws BuildException if the listeners could not be created.
+     * @noinspection MismatchedJavadocCode
+     * @noinspectionreason MismatchedJavadocCode - until issue #14625
      */
     private AuditListener[] getListeners() {
         final int formatterCount = Math.max(1, formatters.size());

diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/api/FullIdent.java b/src/main/java/com/puppycrawl/tools/checkstyle/api/FullIdent.java
@@ -74,6 +74,8 @@ public static FullIdent createFullIdent(DetailAST ast) {
      *
      * @param full the FullIdent to add to
      * @param ast the node to recurse from
+     * @noinspection TailRecursion
+     * @noinspectionreason TailRecursion - until issue #14625
      */
     private static void extractFullIdent(FullIdent full, DetailAST ast) {
         if (ast != null) {

diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/annotation/SuppressWarningsCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/annotation/SuppressWarningsCheck.java
@@ -309,6 +309,8 @@ private static String removeQuotes(final String warning) {
      *
      * @param cond a Conditional type
      *     {@link TokenTypes#QUESTION QUESTION}
+     * @noinspection TailRecursion
+     * @noinspectionreason TailRecursion - until issue #14625
      */
     private void walkConditional(final DetailAST cond) {
         if (cond.getType() == TokenTypes.QUESTION) {

diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/EqualsAvoidNullCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/EqualsAvoidNullCheck.java
@@ -635,6 +635,8 @@ public void addMethodCall(DetailAST methodCall) {
          *
          * @param name name of the field to check.
          * @return true if this FieldFrame contains instance field.
+         * @noinspection MismatchedJavadocCode
+         * @noinspectionreason MismatchedJavadocCode - until issue #14625
          */
         public DetailAST findField(String name) {
             return fieldNameToAst.get(name);

diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/HiddenFieldCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/HiddenFieldCheck.java
@@ -649,6 +649,8 @@ public void addStaticField(String field) {
          *
          * @param field the field to check
          * @return true if this FieldFrame contains instance field
+         * @noinspection TailRecursion
+         * @noinspectionreason TailRecursion - until issue #14625
          */
         public boolean containsInstanceField(String field) {
             return instanceFields.contains(field)
@@ -661,6 +663,8 @@ public boolean containsInstanceField(String field) {
          *
          * @param field the field to check
          * @return true if this FieldFrame contains static field
+         * @noinspection TailRecursion
+         * @noinspectionreason TailRecursion - until issue #14625
          */
         public boolean containsStaticField(String field) {
             return staticFields.contains(field)

diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/UnusedLocalVariableCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/UnusedLocalVariableCheck.java
@@ -522,6 +522,8 @@ private void modifyVariablesStack(TypeDeclDesc obtainedClass,
      *
      * @param superClassName name of the super class
      * @return true if there is another type declaration with same name.
+     * @noinspection MismatchedJavadocCode
+     * @noinspectionreason MismatchedJavadocCode - until issue #14625
      */
     private List<TypeDeclDesc> typeDeclWithSameName(String superClassName) {
         return typeDeclAstToTypeDeclDesc.values().stream()

diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/regexp/RegexpCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/regexp/RegexpCheck.java
@@ -302,7 +302,12 @@ public void beginTree(DetailAST rootAST) {
         findMatch();
     }
 
-    /** Recursive method that finds the matches. */
+    /**
+     * Recursive method that finds the matches.
+     *
+     * @noinspection TailRecursion
+     * @noinspectionreason TailRecursion - until issue #14625
+     */
     // suppress deprecation until https://github.com/checkstyle/checkstyle/issues/11166
     @SuppressWarnings("deprecation")
     private void findMatch() {

diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/regexp/SinglelineDetector.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/regexp/SinglelineDetector.java
@@ -97,6 +97,8 @@ private void resetState() {
      * @param line the line to check
      * @param matcher the matcher to use
      * @param startPosition the position to start searching from.
+     * @noinspection TailRecursion
+     * @noinspectionreason TailRecursion - until issue #14625
      */
     private void checkLine(int lineNo, String line, Matcher matcher,
             int startPosition) {

diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/JavaParserTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/JavaParserTest.java
@@ -57,6 +57,12 @@ public void testNullRootWithComments() {
             .isNull();
     }
 
+    /**
+     * Temporary java doc.
+     *
+     * @noinspection OptionalGetWithoutIsPresent
+     * @noinspectionreason OptionalGetWithoutIsPresent - until issue #14625
+     */
     @Test
     public void testAppendHiddenBlockCommentNodes() throws Exception {
         final DetailAST root =
@@ -99,6 +105,12 @@ public void testAppendHiddenBlockCommentNodes() throws Exception {
             .isEqualTo(1);
     }
 
+    /**
+     * Temporary java doc.
+     *
+     * @noinspection OptionalGetWithoutIsPresent
+     * @noinspectionreason OptionalGetWithoutIsPresent - until issue #14625
+     */
     @Test
     public void testAppendHiddenSingleLineCommentNodes() throws Exception {
         final DetailAST root =
@@ -139,6 +151,12 @@ public void testAppendHiddenSingleLineCommentNodes() throws Exception {
                 .startsWith(" inline comment");
     }
 
+    /**
+     * Temporary java doc.
+     *
+     * @noinspection OptionalGetWithoutIsPresent
+     * @noinspectionreason OptionalGetWithoutIsPresent - until issue #14625
+     */
     @Test
     public void testAppendHiddenSingleLineCommentNodes2() throws Exception {
         final DetailAST root =
@@ -230,6 +248,12 @@ public void testComments() throws Exception {
             .isEqualTo(Arrays.asList("5,4", "8,0"));
     }
 
+    /**
+     * Temporary java doc.
+     *
+     * @noinspection OptionalGetWithoutIsPresent
+     * @noinspectionreason OptionalGetWithoutIsPresent - until issue #14625
+     */
     @Test
     public void testJava14TextBlocks() throws Exception {
         final DetailAST root =

diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/ant/CheckstyleAntTaskTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/ant/CheckstyleAntTaskTest.java
@@ -858,6 +858,12 @@ public void testLoggedTime() throws IOException {
         assertLoggedTime(loggedMessages, testingTime, "To process the files");
     }
 
+    /**
+     * Temporary java doc.
+     *
+     * @noinspection OptionalGetWithoutIsPresent
+     * @noinspectionreason OptionalGetWithoutIsPresent - until issue #14625
+     */
     private static void assertLoggedTime(List<MessageLevelPair> loggedMessages,
                                          long testingTime, String expectedMsg) {
 

diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/SuppressWarningsHolderTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/SuppressWarningsHolderTest.java
@@ -406,6 +406,12 @@ public void testSuppressWarningsAsAnnotationProperty() throws Exception {
         verifyWithInlineConfigParser(getPath("InputSuppressWarningsHolder7.java"), expected);
     }
 
+    /**
+     * Temporary java doc.
+     *
+     * @noinspection OptionalGetWithoutIsPresent
+     * @noinspectionreason OptionalGetWithoutIsPresent - until issue #14625
+     */
     @Test
     @SuppressWarnings("unchecked")
     public void testClearState() throws Exception {

diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/HiddenFieldCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/HiddenFieldCheckTest.java
@@ -500,6 +500,8 @@ public void testHiddenFieldRecordsImplicitlyStaticClassComparison() throws Excep
      * state of the field will be cleared.
      *
      * @throws Exception when code tested throws exception
+     * @noinspection OptionalGetWithoutIsPresent
+     * @noinspectionreason OptionalGetWithoutIsPresent - until issue #14625
      */
     @Test
     public void testClearState() throws Exception {

diff --git a/...est/java/com/puppycrawl/tools/checkstyle/checks/coding/IllegalInstantiationCheckTest.java b/...est/java/com/puppycrawl/tools/checkstyle/checks/coding/IllegalInstantiationCheckTest.java
@@ -166,6 +166,8 @@ public void testImproperToken() {
      * state of the field will be cleared.
      *
      * @throws Exception when code tested throws exception
+     * @noinspection OptionalGetWithoutIsPresent
+     * @noinspectionreason OptionalGetWithoutIsPresent - until issue #14625
      */
     @Test
     @SuppressWarnings("unchecked")
@@ -193,6 +195,8 @@ public void testClearStateClassNames() throws Exception {
      * state of the field will be cleared.
      *
      * @throws Exception when code tested throws exception
+     * @noinspection OptionalGetWithoutIsPresent
+     * @noinspectionreason OptionalGetWithoutIsPresent - until issue #14625
      */
     @Test
     public void testClearStateImports() throws Exception {
@@ -219,6 +223,8 @@ public void testClearStateImports() throws Exception {
      * state of the field will be cleared.
      *
      * @throws Exception when code tested throws exception
+     * @noinspection OptionalGetWithoutIsPresent
+     * @noinspectionreason OptionalGetWithoutIsPresent - until issue #14625
      */
     @Test
     @SuppressWarnings("unchecked")

diff --git a/.../java/com/puppycrawl/tools/checkstyle/checks/coding/ModifiedControlVariableCheckTest.java b/.../java/com/puppycrawl/tools/checkstyle/checks/coding/ModifiedControlVariableCheckTest.java
@@ -178,6 +178,8 @@ public void testRecordDecompositionInEnhancedForLoop() throws Exception {
      * state of the field will be cleared.
      *
      * @throws Exception when code tested throws exception
+     * @noinspection OptionalGetWithoutIsPresent
+     * @noinspectionreason OptionalGetWithoutIsPresent - until issue #14625
      */
     @Test
     @SuppressWarnings("unchecked")

diff --git a/...test/java/com/puppycrawl/tools/checkstyle/checks/coding/ParameterAssignmentCheckTest.java b/...test/java/com/puppycrawl/tools/checkstyle/checks/coding/ParameterAssignmentCheckTest.java
@@ -103,6 +103,8 @@ public void testTokensNotNull() {
      * state of the field will be cleared.
      *
      * @throws Exception when code tested throws exception
+     * @noinspection OptionalGetWithoutIsPresent
+     * @noinspectionreason OptionalGetWithoutIsPresent - until issue #14625
      */
     @Test
     @SuppressWarnings("unchecked")

diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/RequireThisCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/RequireThisCheckTest.java
@@ -562,6 +562,8 @@ public void testUnusedMethodFor() throws Exception {
      * state of the field will be cleared.
      *
      * @throws Exception when code tested throws exception
+     * @noinspection OptionalGetWithoutIsPresent
+     * @noinspectionreason OptionalGetWithoutIsPresent - until issue #14625
      */
     @Test
     public void testClearState() throws Exception {

diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/ReturnCountCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/ReturnCountCheckTest.java
@@ -155,6 +155,8 @@ public void testMaxForVoid() throws Exception {
      * state of the field will be cleared.
      *
      * @throws Exception when code tested throws exception
+     * @noinspection OptionalGetWithoutIsPresent
+     * @noinspectionreason OptionalGetWithoutIsPresent - until issue #14625
      */
     @Test
     @SuppressWarnings("unchecked")

diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/SuperCloneCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/SuperCloneCheckTest.java
@@ -92,6 +92,8 @@ public void testTokensNotNull() {
      * state of the field will be cleared.
      *
      * @throws Exception when code tested throws exception
+     * @noinspection OptionalGetWithoutIsPresent
+     * @noinspectionreason OptionalGetWithoutIsPresent - until issue #14625
      */
     @Test
     @SuppressWarnings("unchecked")

diff --git a/...test/java/com/puppycrawl/tools/checkstyle/checks/coding/UnusedLocalVariableCheckTest.java b/...test/java/com/puppycrawl/tools/checkstyle/checks/coding/UnusedLocalVariableCheckTest.java
@@ -360,6 +360,12 @@ public void testUnusedLocalVariableTernaryAndExpressions() throws Exception {
                 expected);
     }
 
+    /**
+     * Temporary java doc.
+     *
+     * @noinspection OptionalGetWithoutIsPresent
+     * @noinspectionreason OptionalGetWithoutIsPresent - until issue #14625
+     */
     @Test
     public void testClearStateVariables() throws Exception {
         final UnusedLocalVariableCheck check = new UnusedLocalVariableCheck();
@@ -382,6 +388,12 @@ public void testClearStateVariables() throws Exception {
                 .isTrue();
     }
 
+    /**
+     * Temporary java doc.
+     *
+     * @noinspection OptionalGetWithoutIsPresent
+     * @noinspectionreason OptionalGetWithoutIsPresent - until issue #14625
+     */
     @Test
     public void testClearStateClasses() throws Exception {
         final UnusedLocalVariableCheck check = new UnusedLocalVariableCheck();
@@ -417,6 +429,12 @@ public void testClearStateClasses() throws Exception {
                 .isTrue();
     }
 
+    /**
+     * Temporary java doc.
+     *
+     * @noinspection OptionalGetWithoutIsPresent
+     * @noinspectionreason OptionalGetWithoutIsPresent - until issue #14625
+     */
     @Test
     public void testClearStateAnonInnerClass() throws Exception {
         final UnusedLocalVariableCheck check = new UnusedLocalVariableCheck();
@@ -451,6 +469,12 @@ public void testClearStateAnonInnerClass() throws Exception {
                 .isTrue();
     }
 
+    /**
+     * Temporary java doc.
+     *
+     * @noinspection OptionalGetWithoutIsPresent
+     * @noinspectionreason OptionalGetWithoutIsPresent - until issue #14625
+     */
     @Test
     public void testClearStatePackageDef() throws Exception {
         final UnusedLocalVariableCheck check = new UnusedLocalVariableCheck();

diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/FinalClassCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/design/FinalClassCheckTest.java
@@ -256,6 +256,8 @@ public void testFinalClassNestedInRecord() throws Exception {
      * state of the field will be cleared.
      *
      * @throws Exception when code tested throws exception
+     * @noinspection OptionalGetWithoutIsPresent
+     * @noinspectionreason OptionalGetWithoutIsPresent - until issue #14625
      */
     @Test
     public void testClearState() throws Exception {

diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/ImportOrderCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/ImportOrderCheckTest.java
@@ -802,6 +802,8 @@ public void testTrimOption() throws Exception {
      * leading to hard-to-detect and unstable violations that will affect our users.
      *
      * @throws Exception when code tested throws exception
+     * @noinspection OptionalGetWithoutIsPresent
+     * @noinspectionreason OptionalGetWithoutIsPresent - until issue #14625
      */
     @Test
     public void testClearState() throws Exception {

diff --git a/...t/java/com/puppycrawl/tools/checkstyle/checks/metrics/ClassFanOutComplexityCheckTest.java b/...t/java/com/puppycrawl/tools/checkstyle/checks/metrics/ClassFanOutComplexityCheckTest.java
@@ -298,6 +298,8 @@ public void testThrows() throws Exception {
      * state of the field will be cleared.
      *
      * @throws Exception when code tested throws exception
+     * @noinspection OptionalGetWithoutIsPresent
+     * @noinspectionreason OptionalGetWithoutIsPresent - until issue #14625
      */
     @Test
     @SuppressWarnings("unchecked")
@@ -325,6 +327,8 @@ public void testClearStateImportedClassPackages() throws Exception {
      * state of the field will be cleared.
      *
      * @throws Exception when code tested throws exception
+     * @noinspection OptionalGetWithoutIsPresent
+     * @noinspectionreason OptionalGetWithoutIsPresent - until issue #14625
      */
     @Test
     public void testClearStateClassContexts() throws Exception {
@@ -351,6 +355,8 @@ public void testClearStateClassContexts() throws Exception {
      * state of the field will be cleared.
      *
      * @throws Exception when code tested throws exception
+     * @noinspection OptionalGetWithoutIsPresent
+     * @noinspectionreason OptionalGetWithoutIsPresent - until issue #14625
      */
     @Test
     public void testClearStatePackageName() throws Exception {

diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/metrics/NPathComplexityCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/metrics/NPathComplexityCheckTest.java
@@ -161,6 +161,12 @@ public void testStatefulFieldsClearedOnBeginTree2() {
                 .isTrue();
     }
 
+    /**
+     * Temporary java doc.
+     *
+     * @noinspection OptionalGetWithoutIsPresent
+     * @noinspectionreason OptionalGetWithoutIsPresent - until issue #14625
+     */
     @Test
     public void testStatefulFieldsClearedOnBeginTree3() throws Exception {
         final NPathComplexityCheck check = new NPathComplexityCheck();

diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/sizes/OuterTypeNumberCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/sizes/OuterTypeNumberCheckTest.java
@@ -116,6 +116,8 @@ public void testWithRecords() throws Exception {
      * check as they are file specific values.
      *
      * @throws Exception if there is an error.
+     * @noinspection OptionalGetWithoutIsPresent
+     * @noinspectionreason OptionalGetWithoutIsPresent - until issue #14625
      */
     @Test
     public void testClearState() throws Exception {

diff --git a/...st/java/com/puppycrawl/tools/checkstyle/checks/whitespace/GenericWhitespaceCheckTest.java b/...st/java/com/puppycrawl/tools/checkstyle/checks/whitespace/GenericWhitespaceCheckTest.java
@@ -277,6 +277,8 @@ public void testBeforeRecordHeader() throws Exception {
      * start of processing the next file in the check.
      *
      * @throws Exception if there is an error.
+     * @noinspection OptionalGetWithoutIsPresent
+     * @noinspectionreason OptionalGetWithoutIsPresent - until issue #14625
      */
     @Test
     public void testClearState() throws Exception {

diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/internal/XdocsJavaDocsTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/internal/XdocsJavaDocsTest.java
@@ -126,9 +126,10 @@ public void setUp() throws Exception {
     /**
      * Validates check javadocs and xdocs for consistency.
      *
-     * @noinspection JUnitTestMethodWithNoAssertions
+     * @noinspection JUnitTestMethodWithNoAssertions, TestMethodWithoutAssertion
      * @noinspectionreason JUnitTestMethodWithNoAssertions - asserts in callstack,
      *      but not in this method
+     * @noinspectionreason TestMethodWithoutAssertion - until issue #14625
      */
     @Test
     public void testAllCheckSectionJavaDocs() throws Exception {