Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML comments break the Javadoc style HTML check #119

Closed
theqaguy opened this issue Mar 13, 2014 · 3 comments
Closed

HTML comments break the Javadoc style HTML check #119

theqaguy opened this issue Mar 13, 2014 · 3 comments

Comments

@theqaguy
Copy link
Contributor

If the javadoc contains html tags and those tags include a comment () the detection of unclosed tags is broken.

Example:

/**
* <pre>
*text
*<!-- comment -->
*text
* </pre>
**/
public void method() {}

This will report an unclosed <pre> tag - which is not correct. The issue is caused by a "off by one" problem in the TagParser class.

Please see the attached patch file (rename .png to .patch) for a new test, test data and a fixed TagParser.

Greets!
htmlcommentfix2

@theqaguy
Copy link
Contributor Author

What I forgot to mention: This issue & fix are related to the released 5.7 version.

@isopov isopov added the bug label Mar 13, 2014
@romani
Copy link
Member

romani commented Mar 23, 2014

please do patch one more time I can not see it.
advice: please push changes in your checkstyle fork and do it throught PullRequest or send me link to your commit.

@theqaguy
Copy link
Contributor Author

Thanks for your feedback. I created a pull request now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants