Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create Github action that does version bump and update of milestone #11900

Closed
romani opened this issue Jul 16, 2022 · 4 comments · Fixed by #11993
Closed

create Github action that does version bump and update of milestone #11900

romani opened this issue Jul 16, 2022 · 4 comments · Fixed by #11993

Comments

@romani
Copy link
Member

romani commented Jul 16, 2022

https://github.com/checkstyle/contribution/blob/master/releasenotes-builder/diagrams.md

top and most botton actions of Maintainer is just a version bump to required version and update Github milestone.
we need to have github action that can do this for maintainers.
So this will help to avoid manual operation in terminal by maintainers and just trigger Github action with definition of version and it does job.

So in case of release of bug fix (10.3.1) user will do:

  1. trigger Githib action to update 10.4-SNAPSHOT to 10.3.1-SNAPSHOT
  2. trigger release
  3. trigger Githib action to update 10.3.2-SNAPSHOT to 10.4-SNAPSHOT

we need automation for step 1 and 3.

@Rahulkhinchi03
Copy link
Member

for this, do we need 2 shell scripts? one for version bump by GitHub API and one for an update of the milestone by maven command? or can instead of creating a shell script, should we just run the command in GitHub actions?

@romani
Copy link
Member Author

romani commented Jul 17, 2022

In my mind it was one sh file that do both: bump, push, update milestone.
But if you see reason to have two, ok, send PR, we will see.

Action should run such script.

@Rahulkhinchi03
Copy link
Member

  • trigger Githib action to update 10.4-SNAPSHOT to 10.3.1-SNAPSHOT
  • trigger release
  • trigger Githib action to update 10.3.2-SNAPSHOT to 10.4-SNAPSHOT

Why do we need step 3? Also, Should I create another shell script for step3 to make it more clear and not generalized.

@romani
Copy link
Member Author

romani commented Jul 24, 2022

It is same script, the same operations as in first step.

It use to be required, as next version of checkstyle was in many places, so I always kept it on major version increment. But we most likely change this.

For now it is just execution of same action/script as in first , you do not need to create anything extra.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
2 participants