ClassNotFoundException when using inherited exception #1192
Comments
|
all functionality base on loading class from classpath is deprecated now (due to a lot of bugs and no reliable way to do that for now) please try to use option Let me know if that does not help. |
|
I think you mean to set |
|
thanks, if you already see how to fix that please be welcome with PR. |
|
I think it should be sufficient to catch the NoClassDefFoundError in either the isLoadable method of ClassResolver or the resolveClass method of AbstractTypeAwareCheck. |
|
That is classpath managmend that checkstyle-maven-plugin provide. Please report additional issue to that project. |
|
@Vladlis , please help us with that issue. |
|
very strange issue as due to javadoc - only ClassNotFoundException is expected as we use "Class.forName". We can not create a test for that as we receive only ClassNotFoundException, so we will do blind extending of code to catch NoClassDefFoundError. |
|
merged. |
I also added some unchecked exceptions to a couple methods' throws declarations to work around Checkstyle bug 1192[1]. [1] checkstyle/checkstyle#1192
JavadocMethodCheck is used.
I have a custom exception class which extends NestableRuntimeException from commons-lang 2.6:
public class ApplicationException extends NestableRuntimeException { ... }The custom exception and the code calling it are in my own jar file, while the NestableRuntimeException is in a Maven dependency. When I run checkstyle via maven-checkstyle-plugin, this always results in a stacktrace:
[INFO] Generating "Checkstyle" report --- maven-checkstyle-plugin:2.15:checkstyle-aggregate java.lang.NoClassDefFoundError: org/apache/commons/lang/exception/NestableRuntimeException at java.lang.ClassLoader.defineClass1(Native Method) at java.lang.ClassLoader.defineClass(ClassLoader.java:800) at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142) at java.net.URLClassLoader.defineClass(URLClassLoader.java:449) at java.net.URLClassLoader.access$100(URLClassLoader.java:71) at java.net.URLClassLoader$1.run(URLClassLoader.java:361) at java.net.URLClassLoader$1.run(URLClassLoader.java:355) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:354) at java.lang.ClassLoader.loadClass(ClassLoader.java:425) at java.lang.ClassLoader.loadClass(ClassLoader.java:358) at java.lang.Class.forName0(Native Method) at java.lang.Class.forName(Class.java:274) at com.puppycrawl.tools.checkstyle.checks.ClassResolver.safeLoad(ClassResolver.java:153) at com.puppycrawl.tools.checkstyle.checks.ClassResolver.isLoadable(ClassResolver.java:132) at com.puppycrawl.tools.checkstyle.checks.ClassResolver.resolveQualifiedName(ClassResolver.java:164) at com.puppycrawl.tools.checkstyle.checks.ClassResolver.resolve(ClassResolver.java:83) at com.puppycrawl.tools.checkstyle.checks.AbstractTypeAwareCheck.resolveClass(AbstractTypeAwareCheck.java:247) at com.puppycrawl.tools.checkstyle.checks.AbstractTypeAwareCheck.tryLoadClass(AbstractTypeAwareCheck.java:262) at com.puppycrawl.tools.checkstyle.checks.AbstractTypeAwareCheck$RegularClass.getClazz(AbstractTypeAwareCheck.java:486) at com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck.checkThrowsTags(JavadocMethodCheck.java:844) at com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck.checkComment(JavadocMethodCheck.java:439) at com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck.processAST(JavadocMethodCheck.java:325) at com.puppycrawl.tools.checkstyle.checks.AbstractTypeAwareCheck.visitToken(AbstractTypeAwareCheck.java:149) at com.puppycrawl.tools.checkstyle.TreeWalker.notifyVisit(TreeWalker.java:448) at com.puppycrawl.tools.checkstyle.TreeWalker.processIter(TreeWalker.java:541) at com.puppycrawl.tools.checkstyle.TreeWalker.walk(TreeWalker.java:373) at com.puppycrawl.tools.checkstyle.TreeWalker.processFiltered(TreeWalker.java:211) at com.puppycrawl.tools.checkstyle.api.AbstractFileSetCheck.process(AbstractFileSetCheck.java:73) at com.puppycrawl.tools.checkstyle.Checker.process(Checker.java:263) at org.apache.maven.plugin.checkstyle.exec.DefaultCheckstyleExecutor.executeCheckstyle(DefaultCheckstyleExecutor.java:253) at org.apache.maven.plugin.checkstyle.AbstractCheckstyleReport.executeReport(AbstractCheckstyleReport.java:473) at org.apache.maven.reporting.AbstractMavenReport.generate(AbstractMavenReport.java:255) at org.apache.maven.plugins.site.render.ReportDocumentRenderer.renderDocument(ReportDocumentRenderer.java:224) at org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.renderModule(DefaultSiteRenderer.java:311) at org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.render(DefaultSiteRenderer.java:129) at org.apache.maven.plugins.site.render.SiteMojo.renderLocale(SiteMojo.java:182) at org.apache.maven.plugins.site.render.SiteMojo.execute(SiteMojo.java:141) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:132) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80) at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51) at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:120) at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:355) at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:155) at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584) at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:216) at org.apache.maven.cli.MavenCli.main(MavenCli.java:160) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289) at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229) at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415) at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356) Caused by: java.lang.ClassNotFoundException: org.apache.commons.lang.exception.NestableRuntimeException at java.net.URLClassLoader$1.run(URLClassLoader.java:366) at java.net.URLClassLoader$1.run(URLClassLoader.java:355) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:354) at java.lang.ClassLoader.loadClass(ClassLoader.java:425) at java.lang.ClassLoader.loadClass(ClassLoader.java:358) ... 59 more [INFO] There are 896 errors reported by Checkstyle 6.1.1 with config/sun_checks.xml ruleset.The same happens with checkstyle 6.7.
A similar issue was posted here: https://groups.google.com/forum/#!topic/checkstyle/9Yae7DL1kdo
The text was updated successfully, but these errors were encountered: