You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Filters have no way to collect the file source from the AuditEvents as the class does not carry that information and there is no other interactions to get this information from,
We should expand normal AuditEvents to also send the source to be used in filters when it concerns violations to be used in filters.
Doing this may allow us to deprecate SuppressWarningsHolder as it is not really considered appropriate for how it does it's functionality. This won't allow removing SuppressWarningsHolder because the check still analyzes the AST. Maybe it should be considered if it should be a TreeWalker filter.
The text was updated successfully, but these errors were encountered:
Identified at #12151 (comment) ,
Filters have no way to collect the file source from the AuditEvents as the class does not carry that information and there is no other interactions to get this information from,
TreeWalkerAuditEvents do actually collect the file source and are able to pass that on to TreeWalkerFilters.
We should expand normal AuditEvents to also send the source to be used in filters when it concerns violations to be used in filters.
Doing this may allow us to deprecate SuppressWarningsHolder as it is not really considered appropriate for how it does it's functionality.This won't allow removingSuppressWarningsHolder
because the check still analyzes the AST. Maybe it should be considered if it should be aTreeWalker
filter.The text was updated successfully, but these errors were encountered: