Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuditEvents: Allow to Pass File Source #12242

Open
rnveach opened this issue Oct 1, 2022 · 0 comments
Open

AuditEvents: Allow to Pass File Source #12242

rnveach opened this issue Oct 1, 2022 · 0 comments
Labels

Comments

@rnveach
Copy link
Member

rnveach commented Oct 1, 2022

Identified at #12151 (comment) ,

Filters have no way to collect the file source from the AuditEvents as the class does not carry that information and there is no other interactions to get this information from,

TreeWalkerAuditEvents do actually collect the file source and are able to pass that on to TreeWalkerFilters.

We should expand normal AuditEvents to also send the source to be used in filters when it concerns violations to be used in filters.

Doing this may allow us to deprecate SuppressWarningsHolder as it is not really considered appropriate for how it does it's functionality. This won't allow removing SuppressWarningsHolder because the check still analyzes the AST. Maybe it should be considered if it should be a TreeWalker filter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants