CommitValidationTest fails on revert commits

[stoyanK7]

Commit: 26cadbb
Message: Revert "doc: release notes for 10.8.0"
Pipeline fail: https://dev.azure.com/romanivanovjr/romanivanovjr/_build/results?buildId=13264&view=logs&j=c902ebb4-c9f8-5f09-4e17-ff78fbbc842e&t=9ca98c81-ff64-58f0-9d03-a23ac1c4a111&l=795

[ERROR] Failures: 
[ERROR]   CommitValidationTest.testCommitMessageHasProperStructure:183 Commit 26cadbb6772aa6ca85d6e95a9bff5d5366ca0430 message: "Revert "doc: release notes for 10.8.0"\n\nThis reverts commit ff8bcc73c3c22161656794c969bb28a8cb09595f.\n" is invalid
Proper commit message should adhere to the following rules:
    1) Must match one of the following patterns:
        ^Issue #\d+: .*$
        ^Pull #\d+: .*$
        ^(minor|config|infra|doc|spelling|dependency|supplemental): .*$
    2) It contains only one line of text
    3) Must not end with a period, space, or tab
    4) Commit message should be less than or equal to 200 characters

The rule broken was: 1
[INFO] 
[ERROR] Tests run: 3931, Failures: 1, Errors: 0, Skipped: 2

[romani]

Reverts should be excluded from validation. I thought we already had support for this.

[stoyanK7]

On it,

[stoyanK7]

So the check regex would be ^Revert .*

Take for example the commit message

Revert "doc: release notes for 10.8.0"
This reverts commit ff8bcc73c3c22161656794c969bb28a8cb09595f.

and the code that checks it

checkstyle/src/test/java/com/puppycrawl/tools/checkstyle/internal/CommitValidationTest.java

Lines 204 to 231 in bbfa7fb

	private static int validateCommitMessage(String commitMessage) {
	final String message = commitMessage.replace("\r", "").replace("\n", "");
	final String trimRight = commitMessage.replaceAll("[\\r\\n]+$", "");
	final int result;
	if (!ACCEPTED_COMMIT_MESSAGE_PATTERN.matcher(message).matches()) {
	// improper prefix
	result = 1;
	}
	else if (!trimRight.equals(message)) {
	// single-line of text (multiple new lines are allowed on end because of
	// git (1 new line) and GitHub's web ui (2 new lines))
	result = 2;
	}
	else if (INVALID_POSTFIX_PATTERN.matcher(message).matches()) {
	// improper postfix
	result = 3;
	}
	else if (message.length() > 200) {
	// commit message has more than 200 characters
	result = 4;
	}
	else {
	result = 0;
	}
	return result;
	}

Problem is that it violates second(else if (!trimRight.equals(message))) and third(else if (INVALID_POSTFIX_PATTERN.matcher(message).matches())) checks.

Shall we just this at the end of the file to work around all of this?

        if (message.matches(REVERT_COMMIT_MESSAGE_REGEX_PATTERN)) {
            result = 0;
        }

[romani]

Yes, if it is revert commit, no more validation should be applied.