Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move all example tests to extend AbstractExamplesModuleTestSupport #13496

Closed
stoyanK7 opened this issue Aug 1, 2023 · 1 comment · Fixed by #13497
Closed

Move all example tests to extend AbstractExamplesModuleTestSupport #13496

stoyanK7 opened this issue Aug 1, 2023 · 1 comment · Fixed by #13497
Labels
approved miscellaneous
Milestone
10.12.3

Comments

@stoyanK7
Copy link
Collaborator

stoyanK7 commented Aug 1, 2023

In #13489 we add a new class AbstractExamplesModuleTestSupport that all example tests should extend. The reason is that there were some tests with swapped getPackageLocation and getResourceLocation.

The purpose of this issue is to convert the rest of the suite to extend this class.
@stoyanK7 stoyanK7 mentioned this issue Aug 1, 2023
Merged
@romani romani added the approved label Aug 1, 2023
nrmancuso pushed a commit that referenced this issue Aug 1, 2023
@stoyanK7 @nrmancuso
Issue #13496: Move all example tests to extend AbstractExamplesModule…
7634a40 
…TestSupport
@github-actions github-actions bot added this to the 10.12.3 milestone Aug 1, 2023
@nrmancuso
Copy link
Member

Closed via #13497

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved miscellaneous
Projects
Xdoc generation
Status: Done
Milestone
10.12.3
Development

Successfully merging a pull request may close this issue.

Issue #13496: Move all example tests to extend AbstractExamplesModuleTestSupport stoyanK7/checkstyle
3 participants
@romani @stoyanK7 @nrmancuso