Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo #13735

Closed
Bananeweizen opened this issue Sep 13, 2023 · 6 comments
Closed

Typo #13735

Bananeweizen opened this issue Sep 13, 2023 · 6 comments
Labels
approved easy miscellaneous
Milestone
10.12.4

Comments

@Bananeweizen
Copy link
Contributor

https://checkstyle.org/checks/javadoc/invalidjavadocposition.html#InvalidJavadocPosition

This comment looks like javadoc but it at an invalid location.

  • but it is at an...
  • Javadoc should be uppercase here (only the javadoc tool is lowercase, the documentation itself is uppercase)
@Clint-Mathews
Copy link
Contributor

Clint-Mathews commented Sep 13, 2023 •
edited

Hey @Bananeweizen can I pick this up? Just starting with open source 😅

@Bananeweizen
Copy link
Contributor Author

@Clint-Mathews sure. please be aware I'm not a project member, just the author of the issue.

@romani
Copy link
Member

romani commented Sep 13, 2023

@Clint-Mathews, please help us, referenced text in our GitHub repo, just search and change it.

Clint-Mathews pushed a commit to Clint-Mathews/checkstyle that referenced this issue Sep 14, 2023
fix: checkstyle#13735 - Fixed typo in files invalidjavadocposition.xm…
d48bcf6 
…l and Example1.txt
Clint-Mathews pushed a commit to Clint-Mathews/checkstyle that referenced this issue Sep 14, 2023
Issue checkstyle#13735: Fixed typo in files invalidjavadocposition.xm…
16ba353 
…l and Example1.txt
Clint-Mathews pushed a commit to Clint-Mathews/checkstyle that referenced this issue Sep 14, 2023
@Clint-Mathews
Issue checkstyle#13735: Fixed typo in files invalidjavadocposition.xm…
348e84a 
…l and Example1.txt
Clint-Mathews added a commit to Clint-Mathews/checkstyle that referenced this issue Sep 14, 2023
@Clint-Mathews
Issue checkstyle#13735: Fixed typo in files invalidjavadocposition.xm…
c322781 
…l and Example1.txt
@Clint-Mathews
Copy link
Contributor

@romani Raised an MR with fix!

@Clint-Mathews Clint-Mathews mentioned this issue Sep 14, 2023
Merged
romani pushed a commit that referenced this issue Sep 14, 2023
@Clint-Mathews @romani
Issue #13735: Fixed typo in files invalidjavadocposition.xml and Exam…
2965db1 
…ple1.txt
@romani
Copy link
Member

romani commented Sep 14, 2023

Fix is merged.

@romani romani closed this as completed Sep 14, 2023
@romani
Copy link
Member

romani commented Sep 14, 2023

@Clint-Mathews , thanks a lot for help, please help us to fix more.

@github-actions github-actions bot added this to the 10.12.4 milestone Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved easy miscellaneous
Projects
None yet
Milestone
10.12.4
Development

No branches or pull requests
3 participants
@Bananeweizen @romani @Clint-Mathews