Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: actionlint bad yaml #13765

Closed
Bananeweizen opened this issue Sep 23, 2023 · 10 comments
Closed

infra: actionlint bad yaml #13765

Bananeweizen opened this issue Sep 23, 2023 · 10 comments

Comments

@Bananeweizen
Copy link
Contributor

should be an array, not just a string

grafik

@nrmancuso
Copy link
Member

@rnveach
Copy link
Member

rnveach commented Sep 24, 2023

This is eclipse. I see the same thing on mine, 2022-06.

Jump to schema location takes the user to https://json.schemastore.org/github-workflow.json

@Bananeweizen
Copy link
Contributor Author

@rnveach You should really upgrade more often. You are missing so many new features and bug fixes. I regularly develop on milestone and snapshot releases, and even those are typically quite stable.

@rnveach
Copy link
Member

rnveach commented Sep 24, 2023

I am connected to the version I use at work. I did recently get the 2023-06, but I haven't switched over my personal yet.

@romani
Copy link
Member

romani commented Sep 24, 2023

Let's try to fix it if it is not conflicts with some other validation.

@AayushSaini101
Copy link
Contributor

@romani Can I take this issue? I read the documentation, We can mention master and * as mentioned in the official doc

@Bananeweizen
Copy link
Contributor Author

BTW: eclipse-cs meanwhile has a copy of this action, with a fix applied already: https://github.com/checkstyle/eclipse-cs/blob/master/.github/workflows/actionlint.yml#L10 However, since it has not yet run in the eclipse-cs repo, I can't say anything about whether it works correctly there. :)

@romani
Copy link
Member

romani commented Oct 3, 2023

@AayushSaini101 , you can take any approved issue, just recheck that nobody made comment "I am on it" before, and do comment "I am on it", and send fix.

@AayushSaini101
Copy link
Contributor

@AayushSaini101 , you can take any approved issue, just recheck that nobody made comment "I am on it" before, and do comment "I am on it", and send fix.

Thanks @romani I am on it

@romani
Copy link
Member

romani commented Oct 9, 2023

Fix is merged

@romani romani closed this as completed Oct 9, 2023
@github-actions github-actions bot added this to the 10.12.5 milestone Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants