-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #14937: Migrated section 3.3.2 No Line-Wrapping to Chapter Wise Testing #15099
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
item
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok to merge
@Zopsss , please resolve conflict |
CI is green, @rdiachenko , please finalize review |
|
||
final Integer[] warnList = getLinesWithWarn(filePath); | ||
verify(checkConfig, filePath, expected, warnList); | ||
verifyWithConfigParser(modules, filePath); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renamed the verify method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@Zopsss , please resolve conflict |
…apter Wise Testing
@romani done 🏓 |
#14937
There were 3 input files originally, one with bad imports, one with good imports and one with longer import. So I just combined them into single input.
Also kept the extra code to prove that LineLength is disabled for imports but not for other code