Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull #3263: corrected alphabetical order of the checks #3263

Merged
merged 2 commits into from Jun 12, 2016
Merged

Pull #3263: corrected alphabetical order of the checks #3263

merged 2 commits into from Jun 12, 2016

Conversation

f05fk
Copy link
Contributor

@f05fk f05fk commented Jun 10, 2016

The "Checks" page lists the available checks in alphabetical order and even says that it does. Therefore I corrected the order of some checks, because they have not been in the right place.

@f05fk f05fk changed the title corrected alphabetical order of the checks Pull #3263: corrected alphabetical order of the checks Jun 10, 2016
@codecov-io
Copy link

codecov-io commented Jun 10, 2016

Current coverage is 100%

Merging #3263 into master will not change coverage

@@             master      #3263   diff @@
==========================================
  Files           276        276          
  Lines         13948      13978    +30   
  Methods           0          0          
  Messages          0          0          
  Branches       3236       3246    +10   
==========================================
+ Hits          13948      13978    +30   
  Misses            0          0          
  Partials          0          0          

Powered by Codecov. Last updated by ae254f7...aac3a2f

@rnveach
Copy link
Member

rnveach commented Jun 10, 2016

@f05fk
When we sort checks on other pages, we sort them ignoring case. We should probably continue that type of sorting here.
See https://github.com/checkstyle/checkstyle/blob/master/src/test/java/com/puppycrawl/tools/checkstyle/internal/XDocsPagesTest.java#L283-L287

Here are some other changes based on that type of sorting:
JavaNCSS should come after JavadocVariable, NPathComplexity should come after NoWhitespaceBefore, NonEmptyAtclauseDescription should come after NoLineWrap (not NoWhitespaceBefore), TypeName should come after TypecastParenPad.

@f05fk
Copy link
Contributor Author

f05fk commented Jun 11, 2016

Ok. Good argument. I also find it more natural to sort case-insensitive but I tried to stick with the existing case-sensitive sorting in my first attempt. I'll apply the suggested changes.

@romani romani merged commit bca44e5 into checkstyle:master Jun 12, 2016
@romani
Copy link
Member

romani commented Jun 12, 2016

merged by web ui, commit message is "Pull #3263: corrected case-insensitive alphabetical order of the checks"

@romani romani added this to the 7.0 milestone Jun 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants