Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean API methods and other methods from word "Error" #3544

Open
romani opened this issue Nov 11, 2016 · 2 comments
Open

clean API methods and other methods from word "Error" #3544

romani opened this issue Nov 11, 2016 · 2 comments
Labels

Comments

@romani
Copy link
Member

romani commented Nov 11, 2016

Error is a severity of violation. We report violations to user, severity of it is up to user.

There are number of methods, even non API, that mislead by name - should be fixed. Proposed term - violation .

old API methods could be marked as deprecated for few releases to let users be ready.

There bunch of terms in our API (about the same):
MessageDispatcher
LocalizedMessage
AuditEvent
Error

proposal is to use the same terminology:
MessageDispatcher ===> ViolationDispatcher ( ideally to make it ViolationListener)
LocalizedMessage ==>LocalizedViolation
AuditEvent ===> Violation

if you know better names - please suggest.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@rnveach
Copy link
Member

rnveach commented Aug 14, 2021

@romani confirm issue and names are still valid.

LocalizedMessage ==>LocalizedViolation

This was renamed to Violation.

AuditEvent ===> Violation
Error ==> Violation

I think this was a mistake naming 2 different classes with the same name.

@romani
Copy link
Member Author

romani commented Nov 15, 2021

Fixed.
Error ==> Violation was removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants