Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use ForbidAnnotationElementValueCheck from sevntu.checkstyle #3567

Closed
romani opened this issue Nov 20, 2016 · 4 comments
Closed

use ForbidAnnotationElementValueCheck from sevntu.checkstyle #3567

romani opened this issue Nov 20, 2016 · 4 comments
Assignees
@rnveach
Labels
approved easy miscellaneous
Milestone
8.18

Comments

@romani
Copy link
Member

romani commented Nov 20, 2016 •
edited
Loading

create PR to Checkstyle project to use new Checks at https://github.com/checkstyle/checkstyle/blob/master/config/checkstyle_sevntu_checks.xml

new Check: ForbidAnnotationElementValueCheck, 1.22.0
@romani romani mentioned this issue Nov 20, 2016
Closed
rnveach added a commit to rnveach/checkstyle that referenced this issue Nov 20, 2016
@rnveach
Issue checkstyle#3567: added ForbidAnnotationElementValueCheck
00d6091
rnveach added a commit to rnveach/checkstyle that referenced this issue Nov 20, 2016
@rnveach
Issue checkstyle#3567: clarified tests with expected exceptions
c32285b
@rnveach rnveach mentioned this issue Nov 20, 2016
Merged
@rnveach rnveach self-assigned this Nov 20, 2016
rnveach added a commit to rnveach/checkstyle that referenced this issue Nov 20, 2016
@rnveach
Issue checkstyle#3567: clarified tests with expected exceptions
914f485
rnveach added a commit to rnveach/checkstyle that referenced this issue Nov 22, 2016
@rnveach
Issue checkstyle#3567: clarified tests with expected exceptions
274b8bc
romani pushed a commit that referenced this issue Nov 22, 2016
@rnveach @romani
Issue #3567: added ForbidAnnotationElementValueCheck
a8aece3
romani pushed a commit that referenced this issue Nov 22, 2016
@rnveach @romani
Issue #3567: clarified tests with expected exceptions
f84e26a
@jochenvdv
Copy link
Contributor

jochenvdv commented Jan 13, 2017 •
edited
Loading

Shouldn't this issued be closed? It seems resolved.

@rnveach
Copy link
Member

rnveach commented Jan 13, 2017 •
edited
Loading

@jochenvdv There is one item to look over that romani wasn't happy with on how I transformed it.

checkstyle/src/test/java/com/puppycrawl/tools/checkstyle/checks/imports/ImportOrderCheckTest.java

Line 437 in 1b91687

// -@cs[ForbidAnnotationElementValue] Will examine turkish failure

@rnveach rnveach added the easy label Mar 2, 2017
@rnveach rnveach mentioned this issue Mar 22, 2018
Closed
@rnveach rnveach mentioned this issue Feb 14, 2019
Merged
rnveach added a commit to rnveach/checkstyle that referenced this issue Feb 15, 2019
@rnveach
Issue checkstyle#3567: fixed final ForbidAnnotationElementValueCheck …
dffe0e2 
…violation
@rnveach rnveach mentioned this issue Feb 15, 2019
Merged
romani pushed a commit that referenced this issue Feb 15, 2019
@rnveach @romani
Issue #3567: fixed final ForbidAnnotationElementValueCheck violation
4161929
@romani
Copy link
Member Author

romani commented Feb 15, 2019

@rnveach , Is it done ?

@rnveach
Copy link
Member

rnveach commented Feb 15, 2019

Yes, all fixes are done.

@rnveach rnveach closed this as completed Feb 15, 2019
@rnveach rnveach added this to the 8.18 milestone Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rnveach rnveach

Labels
approved easy miscellaneous
Projects
None yet
Milestone
8.18
Development

No branches or pull requests
3 participants
@romani @rnveach @jochenvdv