Fix AbstractTypeAwareCheck when dealing with nested interfaces #3835
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbstractTypeAwareCheck
looks like it could contain a bug when dealing with interfaces, especially nested interfaces.When we process
visitToken
, we callprocessClass
for classes, interfaces, and enumerations.processClass
manipulatescurrentClassName
and callsprocessTypeParams
to handle the type parameters.When we process
leaveToken
for these tokens we do the same asprocessClass
but reversing it, except we left out interfaces.This fix just adds interface to the tokens we do this action on. Without it, we won't have correct internal variables in nested interfaces after leaving the interface.