Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split and Organize Checkstyle inputs by Test for ExecutableStatementCount #3991

Closed
romani opened this issue Mar 13, 2017 · 5 comments
Closed

Split and Organize Checkstyle inputs by Test for ExecutableStatementCount #3991

romani opened this issue Mar 13, 2017 · 5 comments
Labels
approved easy miscellaneous
Milestone
7.6.1

Comments

@romani
Copy link
Member

romani commented Mar 13, 2017

subtask of #3891 .

do a copy of all test input files to separate folder for ExecutableStatementCount .
Not any other Check should use new inputs.
@romani
Copy link
Member Author

romani commented Mar 13, 2017

pre-assigned to Gabriel Bercaru - https://groups.google.com/forum/#!topic/checkstyle-devel/te3JelPOdGA

@GabrielBercaru
Copy link
Contributor

I am on it

@GabrielBercaru
Copy link
Contributor

GabrielBercaru commented Mar 14, 2017 •
edited

GabrielBercaru@15e6070
#3891
I noticed that throughout all the tests, there was a single input file, InputExecutableStatementCount.java, so this is the only file I've included in the separate folder. Are there any other files I should include in the executablestatementcount folder?

@rnveach
Copy link
Member

rnveach commented Mar 14, 2017

@GabrielBercaru If that is the only input file in the test, then yes, that is the only one that should be in the folder.

This was referenced Mar 14, 2017
Closed
Closed
Merged
romani pushed a commit that referenced this issue Mar 16, 2017
@GabrielBercaru @romani
Issue #3991: Split and Organize Checkstyle inputs by Test for Executa…
62bd23c 
…bleStatementCount
@romani romani added this to the 7.7 milestone Mar 16, 2017
@romani
Copy link
Member Author

romani commented Mar 16, 2017

fix is merged

@romani romani closed this as completed Mar 16, 2017
timurt pushed a commit to timurt/checkstyle that referenced this issue Mar 17, 2017
@GabrielBercaru
Issue checkstyle#3991: Split and Organize Checkstyle inputs by Test f…
5f894bc 
…or ExecutableStatementCount
timurt pushed a commit to timurt/checkstyle that referenced this issue Mar 17, 2017
@GabrielBercaru
Issue checkstyle#3991: Split and Organize Checkstyle inputs by Test f…
14c0176 
…or ExecutableStatementCount
sagar-shah94 pushed a commit to sagar-shah94/checkstyle that referenced this issue Mar 18, 2017
@GabrielBercaru @sagarshah94
Issue checkstyle#3991: Split and Organize Checkstyle inputs by Test f…
7dc7556 
…or ExecutableStatementCount
GitToasterhub pushed a commit to GitToasterhub/checkstyle that referenced this issue Mar 18, 2017
@GabrielBercaru @GitToasterhub
Issue checkstyle#3991: Split and Organize Checkstyle inputs by Test f…
99df41e 
…or ExecutableStatementCount
SergeyDzyuba pushed a commit to SergeyDzyuba/checkstyle that referenced this issue Mar 22, 2017
@GabrielBercaru @SergeyDzyuba
Issue checkstyle#3991: Split and Organize Checkstyle inputs by Test f…
a14c81f 
…or ExecutableStatementCount
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved easy miscellaneous
Projects
None yet
Milestone
7.6.1
Development

No branches or pull requests
3 participants
@romani @rnveach @GabrielBercaru