New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split and Organize Checkstyle inputs by Test for ExecutableStatementCount #3991

Closed
romani opened this Issue Mar 13, 2017 · 5 comments

Comments

Projects
None yet
3 participants
@romani
Member

romani commented Mar 13, 2017

subtask of #3891 .

do a copy of all test input files to separate folder for ExecutableStatementCount .
Not any other Check should use new inputs.

@romani

This comment has been minimized.

Show comment
Hide comment
@GabrielBercaru

This comment has been minimized.

Show comment
Hide comment
@GabrielBercaru

GabrielBercaru Mar 13, 2017

Contributor

I am on it

Contributor

GabrielBercaru commented Mar 13, 2017

I am on it

@GabrielBercaru

This comment has been minimized.

Show comment
Hide comment
@GabrielBercaru

GabrielBercaru Mar 14, 2017

Contributor

GabrielBercaru@15e6070
#3891
I noticed that throughout all the tests, there was a single input file, InputExecutableStatementCount.java, so this is the only file I've included in the separate folder. Are there any other files I should include in the executablestatementcount folder?

Contributor

GabrielBercaru commented Mar 14, 2017

GabrielBercaru@15e6070
#3891
I noticed that throughout all the tests, there was a single input file, InputExecutableStatementCount.java, so this is the only file I've included in the separate folder. Are there any other files I should include in the executablestatementcount folder?

@rnveach

This comment has been minimized.

Show comment
Hide comment
@rnveach

rnveach Mar 14, 2017

Member

@GabrielBercaru If that is the only input file in the test, then yes, that is the only one that should be in the folder.

Member

rnveach commented Mar 14, 2017

@GabrielBercaru If that is the only input file in the test, then yes, that is the only one that should be in the folder.

@romani

This comment has been minimized.

Show comment
Hide comment
@romani

romani Mar 16, 2017

Member

fix is merged

Member

romani commented Mar 16, 2017

fix is merged

@romani romani closed this Mar 16, 2017

timurt pushed a commit to timurt/checkstyle that referenced this issue Mar 17, 2017

timurt pushed a commit to timurt/checkstyle that referenced this issue Mar 17, 2017

sagar-shah94 pushed a commit to sagar-shah94/checkstyle that referenced this issue Mar 18, 2017

GitToasterhub added a commit to GitToasterhub/checkstyle that referenced this issue Mar 18, 2017

SergeyDzyuba added a commit to SergeyDzyuba/checkstyle that referenced this issue Mar 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment