Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade XML logger to XML 1.1 #5168

Open
rnveach opened this issue Oct 2, 2017 · 2 comments
Open

Upgrade XML logger to XML 1.1 #5168

rnveach opened this issue Oct 2, 2017 · 2 comments
Labels

Comments

@rnveach
Copy link
Member

rnveach commented Oct 2, 2017

Identified at #5163 (comment) ,

We need to upgrade our XML output to 1.1 to support escaping non-printable characters like hex 0x01 and 0x02 found in openjdk projects.

Before we can upgrade though, we must have maven-checkstyle-plugin ugpgrade their support of this as they won't accept the newer version of XML.

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (default-cli) on project postgresql: Unable to read Checkstyle results xml: /pipeline/source/pgjdbc/pgjdbc/target/checkstyle-result.xml: only 1.0 is supported as <?xml version not '1.1' (position: START_DOCUMENT seen <?xml version="1.1"... @1:19) -> [Help 1]

@rnveach
Copy link
Member Author

rnveach commented Oct 2, 2017

I have created the issue with maven-checkstyle-plugin at https://issues.apache.org/jira/browse/MCHECKSTYLE-342 .

@romani
Copy link
Member

romani commented Oct 8, 2022

@rnveach , I think it is better to close this PR and wait for plugin to resolve issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants