Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activate checks related to java.io.Closeable #5752

Closed
pbludov opened this issue Apr 22, 2018 · 2 comments
Closed

Activate checks related to java.io.Closeable #5752

pbludov opened this issue Apr 22, 2018 · 2 comments
Labels
approved miscellaneous
Milestone
8.10.1

Comments

@pbludov
Copy link
Member

pbludov commented Apr 22, 2018

Since we no longer use Cobertura, we can force try-with-resources in the code.
There is a couple of Idea rules for that:

  • AutoCloseableResource
  • TryFinallyCanBeTryWithResources

and one Eclipse JDT problem:

  • explicitlyClosedAutoCloseable

If an auto closeable resource can not be wrapped with try-with-resources, the violation should be suppressed.
@pbludov pbludov mentioned this issue Apr 22, 2018
Merged
@romani
Copy link
Member

romani commented Apr 23, 2018

It I'd ok to make fix in few PRs. Simple cases should be merged sooner

romani added a commit that referenced this issue Apr 30, 2018
@romani
Issue #5752: attempt to minimize usage of extra close for resources
2b0ac1b
romani pushed a commit that referenced this issue May 18, 2018
@pbludov @romani
Issue #5752: Activate checks related to java.io.Closeable
effba27
@romani romani added this to the 8.11 milestone May 18, 2018
@romani
Copy link
Member

romani commented May 18, 2018

Fix is merged

@romani romani closed this as completed May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved miscellaneous
Projects
None yet
Milestone
8.10.1
Development

No branches or pull requests
2 participants
@romani @pbludov