Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FinalLocalVariable: NPE with PARAMETER_DEF on methods of inner classes #6375

Closed
rnveach opened this issue Jan 12, 2019 · 1 comment
Closed
Milestone

Comments

@rnveach
Copy link
Member

rnveach commented Jan 12, 2019

$ cat TestClass.java
package com.puppycrawl.tools.checkstyle.checks.coding.requirethis;

public class InputRequireThisReceiver {
    public void foo4(InputRequireThisReceiver this) {}

    private class Inner {
        public Inner(InputRequireThisReceiver InputRequireThisReceiver.this) {}
    }
}


$ cat TestConfig.xml
<?xml version="1.0"?>
<!DOCTYPE module PUBLIC
          "-//Puppy Crawl//DTD Check Configuration 1.3//EN"
          "http://www.puppycrawl.com/dtds/configuration_1_3.dtd">

<module name="Checker">
    <property name="charset" value="UTF-8"/>
    <property name="severity" value="warning"/>
    <property name="haltOnException" value="false"/>

    <module name="TreeWalker">

<module name="FinalLocalVariable">
  <property name="tokens" value="VARIABLE_DEF, PARAMETER_DEF"/>
</module>

    </module>
</module>

$ java -jar checkstyle-8.16-all.jar -c TestConfig.xml TestClass.java
Starting audit...
[ERROR] TestClass.java:1: Got an exception - java.lang.NullPointerException
    at com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck.insertParameter(FinalLocalVariableCheck.java:465)
    at com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck.visitToken(FinalLocalVariableCheck.java:209)
    at com.puppycrawl.tools.checkstyle.TreeWalker.notifyVisit(TreeWalker.java:390)
    at com.puppycrawl.tools.checkstyle.TreeWalker.processIter(TreeWalker.java:501)
    at com.puppycrawl.tools.checkstyle.TreeWalker.walk(TreeWalker.java:330)
    at com.puppycrawl.tools.checkstyle.TreeWalker.processFiltered(TreeWalker.java:183)
    at com.puppycrawl.tools.checkstyle.api.AbstractFileSetCheck.process(AbstractFileSetCheck.java:81)
    at com.puppycrawl.tools.checkstyle.Checker.processFile(Checker.java:319)
    at com.puppycrawl.tools.checkstyle.Checker.processFiles(Checker.java:289)
    at com.puppycrawl.tools.checkstyle.Checker.process(Checker.java:217)
    at com.puppycrawl.tools.checkstyle.Main.runCheckstyle(Main.java:390)
    at com.puppycrawl.tools.checkstyle.Main.runCli(Main.java:313)
    at com.puppycrawl.tools.checkstyle.Main.execute(Main.java:180)
    at com.puppycrawl.tools.checkstyle.Main.main(Main.java:119)
[Checker]
Audit done.
Checkstyle ends with 1 errors.
esilkensen added a commit to esilkensen/checkstyle that referenced this issue Jan 23, 2019
romani pushed a commit that referenced this issue Jan 27, 2019
@romani romani added this to the 8.17 milestone Jan 27, 2019
@romani
Copy link
Member

romani commented Jan 27, 2019

Fix is merged

@romani romani closed this as completed Jan 27, 2019
@romani romani changed the title FinalLocalVariable: NPE FinalLocalVariable: NPE with PARAMETER_DEF on methods of inner classes Jan 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants