Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable PMD rule LinguisticNaming #6578

Closed
pbludov opened this issue Mar 16, 2019 · 2 comments
Closed

Enable PMD rule LinguisticNaming #6578

pbludov opened this issue Mar 16, 2019 · 2 comments

Comments

@pbludov
Copy link
Member

pbludov commented Mar 16, 2019

https://pmd.github.io/latest/pmd_rules_java_codestyle.html#linguisticnaming

Part of #6536

[INFO] PMD Failure: com.puppycrawl.tools.checkstyle.checks.design.VisibilityModifierCheckTest:493
 Rule:LinguisticNaming Priority:3 Linguistics Antipattern - 
The variable 'isStarImport' indicates linguistically it is a boolean, but it is 'Method'.
[INFO] PMD Failure: com.puppycrawl.tools.checkstyle.checks.javadoc.AbstractTypeAwareCheckTest:50
 Rule:LinguisticNaming Priority:3 Linguistics Antipattern - 
The variable 'isSubclass' indicates linguistically it is a boolean, but it is 'Method'.
[INFO] PMD Failure: com.puppycrawl.tools.checkstyle.checks.metrics.NPathComplexityCheck:64 
Rule:LinguisticNaming Priority:3 Linguistics Antipattern - 
The field 'isAfterValues' indicates linguistically it is a boolean, but it is 'Deque'.

@pbludov pbludov mentioned this issue Mar 16, 2019
2 tasks
@romani
Copy link
Member

romani commented Mar 16, 2019

The variable 'isStarImport' indicates linguistically it is a boolean, but it is 'Method'.

        final Method isStarImport = Whitebox.getMethod(VisibilityModifierCheck.class,
"isStarImport", DetailAST.class);

@romani
Copy link
Member

romani commented Mar 17, 2019

Fix is merged

@romani romani closed this as completed Mar 17, 2019
Vantuz pushed a commit to Vantuz/checkstyle that referenced this issue Apr 3, 2019
DXTkastb added a commit to DXTkastb/checkstyle that referenced this issue Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants