Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable PMD rule LinguisticNaming #6578

Closed
pbludov opened this issue Mar 16, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@pbludov
Copy link
Collaborator

commented Mar 16, 2019

https://pmd.github.io/latest/pmd_rules_java_codestyle.html#linguisticnaming

Part of #6536

[INFO] PMD Failure: com.puppycrawl.tools.checkstyle.checks.design.VisibilityModifierCheckTest:493
 Rule:LinguisticNaming Priority:3 Linguistics Antipattern - 
The variable 'isStarImport' indicates linguistically it is a boolean, but it is 'Method'.
[INFO] PMD Failure: com.puppycrawl.tools.checkstyle.checks.javadoc.AbstractTypeAwareCheckTest:50
 Rule:LinguisticNaming Priority:3 Linguistics Antipattern - 
The variable 'isSubclass' indicates linguistically it is a boolean, but it is 'Method'.
[INFO] PMD Failure: com.puppycrawl.tools.checkstyle.checks.metrics.NPathComplexityCheck:64 
Rule:LinguisticNaming Priority:3 Linguistics Antipattern - 
The field 'isAfterValues' indicates linguistically it is a boolean, but it is 'Deque'.

@pbludov pbludov referenced this issue Mar 16, 2019

Closed

Upgrade to PMD 6.12.0 #6536

0 of 2 tasks complete
@romani

This comment has been minimized.

Copy link
Member

commented Mar 16, 2019

The variable 'isStarImport' indicates linguistically it is a boolean, but it is 'Method'.

        final Method isStarImport = Whitebox.getMethod(VisibilityModifierCheck.class,
"isStarImport", DetailAST.class);

@romani romani added the approved label Mar 16, 2019

pbludov added a commit to pbludov/checkstyle that referenced this issue Mar 16, 2019

romani added a commit that referenced this issue Mar 17, 2019

@romani romani added this to the 8.19 milestone Mar 17, 2019

@romani

This comment has been minimized.

Copy link
Member

commented Mar 17, 2019

Fix is merged

@romani romani closed this Mar 17, 2019

Vantuz added a commit to Vantuz/checkstyle that referenced this issue Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.