Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate increase of '-all' jar #6713

Closed
romani opened this issue May 3, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@romani
Copy link
Member

commented May 3, 2019

detected at checkstyle/eclipse-cs#158 (comment)

https://github.com/checkstyle/checkstyle/releases
checkstyle-8.19-all.jar 23.1 MB
checkstyle-8.18-all.jar 11 MB

quick compare of unzipped jars show diff:
Screen Shot 2019-05-03 at 5 55 14 AM

@rnveach

This comment has been minimized.

Copy link
Member

commented May 3, 2019

Printing the results of building the all-jar with debug on shows it is coming from saxon.

[DEBUG]    net.sf.saxon:Saxon-HE:jar:9.9.1-2:compile
[DEBUG]       com.ibm.icu:icu4j:jar:63.1:compile

International Component for Unicode for Java (ICU4J) is a mature, widely used Java library providing Unicode and Globalization support

I downloaded saxon's source zip file and couldn't find any usage of icu.
I did find this on their site: https://sourceforge.net/p/saxon/mailman/message/32363002/
Makes it sound like it is brought in as a driver.

I excluded icu4j from the build and all the tests still pass and the all-jar is back to 11.2 megs.

    <dependency>
      <groupId>net.sf.saxon</groupId>
      <artifactId>Saxon-HE</artifactId>
      <version>${saxon.version}</version>
      <exclusions>
        <exclusion>
          <groupId>com.ibm.icu</groupId>
          <artifactId>icu4j</artifactId>
        </exclusion>
      </exclusions> 
    </dependency>
@romani

This comment has been minimized.

Copy link
Member Author

commented May 3, 2019

Please send PR

rnveach added a commit to rnveach/checkstyle that referenced this issue May 6, 2019

rnveach added a commit to rnveach/checkstyle that referenced this issue May 6, 2019

romani added a commit that referenced this issue May 10, 2019

@romani romani added this to the 8.21 milestone May 10, 2019

@romani

This comment has been minimized.

Copy link
Member Author

commented May 10, 2019

Fix is merged

@romani romani closed this May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.