investigate increase of '-all' jar

[romani]

detected at checkstyle/eclipse-cs#158 (comment)

https://github.com/checkstyle/checkstyle/releases
checkstyle-8.19-all.jar 23.1 MB
checkstyle-8.18-all.jar 11 MB

quick compare of unzipped jars show diff:

[rnveach]

Printing the results of building the all-jar with debug on shows it is coming from saxon.

[DEBUG]    net.sf.saxon:Saxon-HE:jar:9.9.1-2:compile
[DEBUG]       com.ibm.icu:icu4j:jar:63.1:compile

International Component for Unicode for Java (ICU4J) is a mature, widely used Java library providing Unicode and Globalization support

I downloaded saxon's source zip file and couldn't find any usage of icu.
I did find this on their site: https://sourceforge.net/p/saxon/mailman/message/32363002/
Makes it sound like it is brought in as a driver.

I excluded icu4j from the build and all the tests still pass and the all-jar is back to 11.2 megs.

    <dependency>
      <groupId>net.sf.saxon</groupId>
      <artifactId>Saxon-HE</artifactId>
      <version>${saxon.version}</version>
      <exclusions>
        <exclusion>
          <groupId>com.ibm.icu</groupId>
          <artifactId>icu4j</artifactId>
        </exclusion>
      </exclusions> 
    </dependency>

[romani]

Please send PR

[romani]

Fix is merged