Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make inner class SuppressWithNearbyCommentFilter.Tag private #6854

Closed
pbludov opened this issue Jun 26, 2019 · 1 comment
Closed

Make inner class SuppressWithNearbyCommentFilter.Tag private #6854

pbludov opened this issue Jun 26, 2019 · 1 comment
Labels
approved miscellaneous
Milestone
8.23

Comments

@pbludov
Copy link
Member

pbludov commented Jun 26, 2019

Some internal implementation details of the class SuppressWithNearbyCommentFilter are exposed to public. That's not necessary. Moreover, this may cause compatibility issues in the future.
This class should be private. This is a minor change, but may require some changes to the tests.
pbludov added a commit to pbludov/checkstyle that referenced this issue Jun 26, 2019
@pbludov
Issue checkstyle#6854: make SuppressWithNearbyCommentFilter.Tag private
fe347d0
pbludov added a commit to pbludov/checkstyle that referenced this issue Jun 26, 2019
@pbludov
Issue checkstyle#6854: make SuppressWithNearbyCommentFilter.Tag private
a296474
pbludov added a commit to pbludov/checkstyle that referenced this issue Jun 26, 2019
@pbludov
Issue checkstyle#6854: make SuppressWithNearbyCommentFilter.Tag private
26e8a93
pbludov added a commit to pbludov/checkstyle that referenced this issue Jun 26, 2019
@pbludov
Issue checkstyle#6854: make SuppressWithNearbyCommentFilter.Tag private
61fbdbb
@pbludov pbludov mentioned this issue Jun 26, 2019
Merged
pbludov added a commit to pbludov/checkstyle that referenced this issue Jun 27, 2019
@pbludov
Issue checkstyle#6854: make SuppressWithNearbyCommentFilter.Tag private
9ff258a
pbludov added a commit to pbludov/checkstyle that referenced this issue Jun 27, 2019
@pbludov
Issue checkstyle#6854: make SuppressWithNearbyCommentFilter.Tag private
143a257
pbludov added a commit to pbludov/checkstyle that referenced this issue Jun 27, 2019
@pbludov
Issue checkstyle#6854: make SuppressWithNearbyCommentFilter.Tag private
5740a23
pbludov added a commit to pbludov/checkstyle that referenced this issue Jun 27, 2019
@pbludov
Issue checkstyle#6854: make SuppressWithNearbyCommentFilter.Tag private
b72b88a
pbludov added a commit to pbludov/checkstyle that referenced this issue Jun 27, 2019
@pbludov
Issue checkstyle#6854: make SuppressWithNearbyCommentFilter.Tag private
f9f08c1
pbludov added a commit to pbludov/checkstyle that referenced this issue Jul 1, 2019
@pbludov
Issue checkstyle#6854: make SuppressWithNearbyCommentFilter.Tag private
c3c2d83
pbludov added a commit to pbludov/checkstyle that referenced this issue Jul 2, 2019
@pbludov
Issue checkstyle#6854: make SuppressWithNearbyCommentFilter.Tag private
0d18184
romani pushed a commit that referenced this issue Jul 3, 2019
@pbludov @romani
Issue #6854: make SuppressWithNearbyCommentFilter.Tag private
619be72
@romani romani added this to the 8.23 milestone Jul 3, 2019
@romani
Copy link
Member

romani commented Jul 3, 2019

Fix is merged

@romani romani closed this as completed Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved miscellaneous
Projects
None yet
Milestone
8.23
Development

No branches or pull requests
3 participants
@romani @pbludov @rnveach