Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc for JavadocMethod #7598

Closed
baratali opened this issue Feb 23, 2020 · 7 comments · Fixed by #12783
Closed

Update doc for JavadocMethod #7598

baratali opened this issue Feb 23, 2020 · 7 comments · Fixed by #12783

Comments

@baratali
Copy link
Contributor

baratali commented Feb 23, 2020

https://checkstyle.org/config_javadoc.html#JavadocMethod

Add example for each existing config to show what code is ok and what code cause violation.
Good example is https://checkstyle.org/config_naming.html#AbstractClassName
Look at referenced commits of #5832, to see what and how should be changed in code.

Please play with module/check by means of https://checkstyle.org/cmdline.html to understand how it works.


PLEASE READ https://github.com/checkstyle/checkstyle/wiki/Good-practice-on-how-to-update-examples

@checkstyle checkstyle deleted a comment from sudo-andro Apr 21, 2020
@checkstyle checkstyle deleted a comment from Devansu-Yadav Mar 16, 2022
@checkstyle checkstyle deleted a comment from ImmortalRabbit Mar 16, 2022
@checkstyle checkstyle deleted a comment from Tim-Vuong Apr 23, 2022
@checkstyle checkstyle deleted a comment from Tim-Vuong Apr 23, 2022
@checkstyle checkstyle deleted a comment from nrmancuso Apr 23, 2022
@checkstyle checkstyle deleted a comment from Tim-Vuong Apr 23, 2022
@romani
Copy link
Member

romani commented Nov 17, 2022

It is not fixed, everyone in the world can help to fix it.

@checkstyle checkstyle deleted a comment from nitishfy Jan 15, 2023
@checkstyle checkstyle deleted a comment from nitishfy Jan 15, 2023
@rukundob451
Copy link

@romani can I be assigned this issue?

@rnveach
Copy link
Member

rnveach commented Jan 31, 2023

There are no issue assignments. Just say "I am on it" and start working on it.

@aritrasinha108
Copy link
Contributor

Since there are no updates here for a month now, should I start working on it?

@romani
Copy link
Member

romani commented Feb 28, 2023

@aritrasinha108 , please send PR

@aritrasinha108
Copy link
Contributor

@romani one of the tests is failing because of the param tags used as an example. One of the examples I added in /src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocMethodCheck.java looks something like:

* /**
*  * A sample function to print the product two numbers
*  * @param number1 The first number
*  * @param number1 The second number
*  * @return An integer
*  */
* public void multiplyTwoNumbers(int number1, int number2){   // ok, param tags available

when I run mvn clean verify after making the changes, I get this checkstyle fail
Screenshot from 2023-02-28 20-23-11

This happens for all the instances where any tag is used. It's already inside a Javadoc. Not really how to fix this. Could you help me with this?

@aritrasinha108
Copy link
Contributor

Created a PR in case you want to have a look on the changes

aritrasinha108 added a commit to aritrasinha108/checkstyle that referenced this issue Mar 1, 2023
aritrasinha108 added a commit to aritrasinha108/checkstyle that referenced this issue Mar 1, 2023
aritrasinha108 added a commit to aritrasinha108/checkstyle that referenced this issue Mar 5, 2023
aritrasinha108 added a commit to aritrasinha108/checkstyle that referenced this issue Mar 5, 2023
aritrasinha108 added a commit to aritrasinha108/checkstyle that referenced this issue Mar 6, 2023
aritrasinha108 added a commit to aritrasinha108/checkstyle that referenced this issue Mar 6, 2023
aritrasinha108 added a commit to aritrasinha108/checkstyle that referenced this issue Mar 7, 2023
aritrasinha108 added a commit to aritrasinha108/checkstyle that referenced this issue Mar 7, 2023
aritrasinha108 added a commit to aritrasinha108/checkstyle that referenced this issue Mar 7, 2023
aritrasinha108 added a commit to aritrasinha108/checkstyle that referenced this issue Mar 8, 2023
aritrasinha108 added a commit to aritrasinha108/checkstyle that referenced this issue Mar 8, 2023
aritrasinha108 added a commit to aritrasinha108/checkstyle that referenced this issue Mar 8, 2023
aritrasinha108 added a commit to aritrasinha108/checkstyle that referenced this issue Mar 9, 2023
aritrasinha108 added a commit to aritrasinha108/checkstyle that referenced this issue Mar 10, 2023
@github-actions github-actions bot added this to the 10.8.2 milestone Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants