Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc for IllegalInstantiation #7643

Closed
strkkk opened this issue Feb 25, 2020 · 5 comments
Closed

Update doc for IllegalInstantiation #7643

strkkk opened this issue Feb 25, 2020 · 5 comments

Comments

@strkkk
Copy link
Member

strkkk commented Feb 25, 2020

https://checkstyle.org/config_coding.html#IllegalInstantiation

Add example for each existing config to show what code is ok and what code cause violation.
Good example is https://checkstyle.org/config_naming.html#AbstractClassName
Look at referenced commits of #5832, to see what and how should be changed in code.

Please play with module/check by means of https://checkstyle.org/cmdline.html to understand how it works.


PLEASE READ https://github.com/checkstyle/checkstyle/wiki/Good-practice-on-how-to-update-examples

@AmplifiedHuman
Copy link

I am on it

@AmplifiedHuman
Copy link

AmplifiedHuman commented Mar 27, 2020

@strkkk
I am getting this error after running mvn clean verify
AllTestsTest.testAllTestsHaveProductionCode:68->walk:81->lambda$testAllTestsHaveProductionCode$3:69->grabAllFiles:115->getSimplePath:253 » StringIndexOutOfBounds
Is there a specific reason why this is happening?

@romani
Copy link
Member

romani commented Apr 6, 2020

@AmplifiedHuman , please share full log of mvn verify execution by gitst.github.com , and please share your code changes. Can you send a PR with changes.

@himanshurijal
Copy link

I am on it.

@romani
Copy link
Member

romani commented Feb 7, 2021

fix is merged.

@romani romani closed this as completed Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants