Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AbstractChecks to log DetailAST - MissingOverride #7748

Closed
rnveach opened this issue Mar 1, 2020 · 5 comments
Closed

Update AbstractChecks to log DetailAST - MissingOverride #7748

rnveach opened this issue Mar 1, 2020 · 5 comments

Comments

@rnveach
Copy link
Member

rnveach commented Mar 1, 2020

Child of #5777

This issue specifically focuses on MissingOverride.

@HuGanghui
Copy link
Contributor

I am on it~

@HuGanghui
Copy link
Contributor

HuGanghui commented Mar 10, 2020

@rnveach I need some help, when I add IT test, I add some resources in checkstyle/src/it/resources/org/checkstyle/suppressionxpathfilter/missingoverride, but one test failed and I don't know how to solve it, the details as follows:

[ERROR] Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.406 s <<< FAILURE! - in com.puppycrawl.tools.checkstyle.internal.XpathRegressionTest
[ERROR] validateInputFiles Time elapsed: 0.017 s <<< FAILURE!
org.opentest4j.AssertionFailedError: Invalid input file '/Users/hgh/Desktop/checkstyle/src/it/resources/org/checkstyle/suppressionxpathfilter/missingoverride/SupressionXpathRegressionMissingOverrideInterface.java', expected pattern:^SuppressionXpathRegression(.+).java$ ==> expected: but was:
at com.puppycrawl.tools.checkstyle.internal.XpathRegressionTest.validateInputDirectory(XpathRegressionTest.java:298)
at com.puppycrawl.tools.checkstyle.internal.XpathRegressionTest.validateInputFiles(XpathRegressionTest.java:284)

@rnveach
Copy link
Member Author

rnveach commented Mar 10, 2020

SupressionXpathRegressionMissingOverrideInterface

One of the words isn't spelled right. Please look closely at the pattern and the file name you created.

@HuGanghui
Copy link
Contributor

Thanks, my mistake~

HuGanghui added a commit to HuGanghui/checkstyle that referenced this issue Mar 10, 2020
HuGanghui added a commit to HuGanghui/checkstyle that referenced this issue Mar 11, 2020
HuGanghui added a commit to HuGanghui/checkstyle that referenced this issue Mar 13, 2020
@romani romani added the bug label Mar 13, 2020
@romani romani added this to the 8.31 milestone Mar 13, 2020
@romani
Copy link
Member

romani commented Mar 13, 2020

fix is merged.

@romani romani closed this as completed Mar 13, 2020
Abhishek-kumar09 pushed a commit to Abhishek-kumar09/checkstyle that referenced this issue Mar 13, 2020
Abhishek-kumar09 pushed a commit to Abhishek-kumar09/checkstyle that referenced this issue Mar 13, 2020
harsh-kukreja pushed a commit to harsh-kukreja/checkstyle that referenced this issue Mar 14, 2020
ImmortalRabbit pushed a commit to ImmortalRabbit/checkstyle that referenced this issue Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants