Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve Pitest Issues - JavadocMethodCheck (7) #7979

Closed
rnveach opened this issue Mar 28, 2020 · 7 comments
Closed

Resolve Pitest Issues - JavadocMethodCheck (7) #7979

rnveach opened this issue Mar 28, 2020 · 7 comments
Labels
approved good third issue miscellaneous
Milestone
8.33

Comments

@rnveach
Copy link
Member

rnveach commented Mar 28, 2020

Child issue of #7797 ,

checkstyle/.ci/pitest.sh

Line 188 in f9131f9

"JavadocMethodCheck.java.html:<td class='covered'><pre><span class='survived'> currentTypeParams.clear();</span></pre></td></tr>"

@harsh-kukreja
Copy link
Contributor

I'm on it

harsh-kukreja added a commit to harsh-kukreja/checkstyle that referenced this issue Mar 29, 2020
@harsh-kukreja
Issue checkstyle#7979: Resolve Pitest Issues - JavadocMethodCheck (7)
d2b3b31
@harsh-kukreja
Copy link
Contributor

Hey @rnveach or @strkkk

As per my knowledge we can see for each JavadocMethodCheck a new instance will be created so whenever this method is called a new object itself will be created of currentTypeParams

Pitest report:
https://harsh-kukreja.github.io/JavadocMethodCheckPitestReport/com.puppycrawl.tools.checkstyle.checks.javadoc/JavadocMethodCheck.java.html#org.pitest.mutationtest.report.html.SourceFile@18b9ce_383

Hardcoded commit:
d2b3b31

Diff report:
on the way

@harsh-kukreja
Copy link
Contributor

@rnveach please rply

@rnveach
Copy link
Member Author

rnveach commented Apr 1, 2020

@harsh-kukreja What question am I replying to?

@harsh-kukreja
Copy link
Contributor

harsh-kukreja commented Apr 1, 2020 •
edited

Is my report correct if i remove that line ? Should i create a pr stating like this ? @rnveach

@harsh-kukreja
Copy link
Contributor

Hey @rnveach please rply

@harsh-kukreja harsh-kukreja mentioned this issue Apr 13, 2020
Merged
harsh-kukreja added a commit to harsh-kukreja/checkstyle that referenced this issue Apr 16, 2020
@harsh-kukreja
Issue checkstyle#7979: Resolve Pitest Issues - JavadocMethodCheck (7)
4cc856f
harsh-kukreja added a commit to harsh-kukreja/checkstyle that referenced this issue Apr 16, 2020
@harsh-kukreja
Issue checkstyle#7979: Resolve Pitest Issues - JavadocMethodCheck (7)
1fb4610
This was referenced Apr 18, 2020
Closed
Closed
romani pushed a commit that referenced this issue Apr 26, 2020
@harsh-kukreja @romani
Issue #7979: Resolve Pitest Issues - JavadocMethodCheck (7)
caec287
@romani romani added this to the 8.33 milestone Apr 26, 2020
@romani
Copy link
Member

romani commented Apr 26, 2020

fix is merged

@romani romani closed this as completed Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved good third issue miscellaneous
Projects
None yet
Milestone
8.33
Development

No branches or pull requests
3 participants
@romani @rnveach @harsh-kukreja