Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for BeforeExecutionExclusionFileFilter #8269

Closed
romani opened this issue May 29, 2020 · 6 comments
Closed

Update documentation for BeforeExecutionExclusionFileFilter #8269

romani opened this issue May 29, 2020 · 6 comments

Comments

@romani
Copy link
Member

romani commented May 29, 2020

Check documentation: https://checkstyle.org/config_filefilters.html#BeforeExecutionExclusionFileFilter

We need to have example of how user can exclude test folders in projects.

Detected at checkstyle/eclipse-cs#132

@romani
Copy link
Member Author

romani commented Aug 11, 2020

thanks a lot for desire to help
please read #7698
and see latest referenced commit to see where and what was changed.
You just need to change another file, all website doc are in our sources.

@Ritik2604
Copy link
Contributor

I think the previous contributor is not interested If you want me to work on it I will happily do so @romani @timurt

@Ritik2604
Copy link
Contributor

Ritik2604 commented Apr 2, 2021

Just found a new easy way to exclude test directories as well as files for checking which is totally different from this mentioned issue.

Is there an easy way to exclude Maven test directories from checking?
at checkstyle/eclipse-cs#132

Do I add the steps to the Documentation
Step1

sTEP 2

@checkstyle checkstyle deleted a comment from roopbiswas Apr 3, 2021
@romani
Copy link
Member Author

romani commented Apr 3, 2021

We need update on Filter documentation on how to use this Filter in xml config.

We do not need idea setup, we already have it.
https://checkstyle.org/idea.html

@Ritik2604
Copy link
Contributor

Ritik2604 commented Apr 3, 2021

@romani that is not an idea setup I just show how to exclude test files directories for checking. In doc I will write it in steps. As discussed at checkstyle/eclipse-cs#132 that steps are not applicable in new version so thats why these are the steps that will help. At checkstyle/eclipse-cs#132 there are two methods discussed one with xml config and other one the easy one with ide I have to add both methods or only the xml config one. I prefer both.

Ritik2604 added a commit to Ritik2604/checkstyle that referenced this issue Apr 3, 2021
Ritik2604 added a commit to Ritik2604/checkstyle that referenced this issue Apr 3, 2021
Ritik2604 added a commit to Ritik2604/checkstyle that referenced this issue Apr 3, 2021
Ritik2604 added a commit to Ritik2604/checkstyle that referenced this issue Apr 3, 2021
Ritik2604 added a commit to Ritik2604/checkstyle that referenced this issue Apr 3, 2021
Ritik2604 added a commit to Ritik2604/checkstyle that referenced this issue Apr 4, 2021
@romani romani added this to the 8.42 milestone Apr 6, 2021
@romani
Copy link
Member Author

romani commented Apr 6, 2021

merged

@romani romani closed this as completed Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants