Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new Check: PatternVariableName #8407

Closed
nrmancuso opened this issue Jul 6, 2020 · 1 comment
Closed

new Check: PatternVariableName #8407

nrmancuso opened this issue Jul 6, 2020 · 1 comment
Labels
approved new feature new module
Projects
Java 14 syntax features
Milestone
8.36

Comments

@nrmancuso
Copy link
Member

nrmancuso commented Jul 6, 2020 •
edited by romani

Child of #8391
Similar Check: https://checkstyle.sourceforge.io/config_naming.html#LocalVariableName

This check applies to the variable defined in the pattern definition.
From JLS:
Pattern variables are implicitly final by design.

This check should not apply to pattern variable definitions, but since it is still a variable definition, we should make UT to make sure that it stays that way.
@nrmancuso nrmancuso changed the title Java14 enhanced instanceof check validation: LocalVariableNameCheck Introduce Java14 enhanced instanceof syntax check: PatternVariableName Jul 6, 2020
@nrmancuso nrmancuso mentioned this issue Jul 7, 2020
Closed
@romani romani changed the title Introduce Java14 enhanced instanceof syntax check: PatternVariableName new Check: PatternVariableName Jul 7, 2020
@romani romani added the approved label Jul 7, 2020
nrmancuso added a commit to nrmancuso/checkstyle that referenced this issue Jul 7, 2020
@nrmancuso
Issue checkstyle#8407: new Check: PatternVariableName
e14e870
@nrmancuso nrmancuso mentioned this issue Jul 7, 2020
Merged
nrmancuso added a commit to nrmancuso/checkstyle that referenced this issue Jul 7, 2020
@nrmancuso
Issue checkstyle#8407: new Check: PatternVariableName
9abd5c4
nrmancuso added a commit to nrmancuso/checkstyle that referenced this issue Jul 8, 2020
@nrmancuso
Issue checkstyle#8407: new Check: PatternVariableName
8e263e7
nrmancuso added a commit to nrmancuso/checkstyle that referenced this issue Jul 8, 2020
@nrmancuso
Issue checkstyle#8407: new Check: PatternVariableName
95a6d60
nrmancuso added a commit to nrmancuso/checkstyle that referenced this issue Jul 8, 2020
@nrmancuso
Issue checkstyle#8407: new Check: PatternVariableName
5117caf
@esilkensen esilkensen added this to To do in Java 14 syntax features via automation Jul 11, 2020
@esilkensen esilkensen moved this from To do to Review in progress in Java 14 syntax features Jul 11, 2020
nrmancuso added a commit to nrmancuso/checkstyle that referenced this issue Jul 13, 2020
@nrmancuso
Issue checkstyle#8407: new Check: PatternVariableName
74d3dbc
nrmancuso added a commit to nrmancuso/checkstyle that referenced this issue Jul 15, 2020
@nrmancuso
Issue checkstyle#8407: new Check: PatternVariableName
bb9f315
nrmancuso added a commit to nrmancuso/checkstyle that referenced this issue Jul 26, 2020
@nrmancuso
Issue checkstyle#8407: new Check: PatternVariableName
302954a
nrmancuso added a commit to nrmancuso/checkstyle that referenced this issue Jul 26, 2020
@nrmancuso
Issue checkstyle#8407: new Check: PatternVariableName
e167e84
nrmancuso added a commit to nrmancuso/checkstyle that referenced this issue Jul 26, 2020
@nrmancuso
Issue checkstyle#8407: new Check: PatternVariableName
c374bce
romani pushed a commit that referenced this issue Jul 26, 2020
@nrmancuso @romani
Issue #8407: new Check: PatternVariableName
ade141b
@romani romani added this to the 8.36 milestone Jul 26, 2020
@romani
Copy link
Member

romani commented Jul 26, 2020

Fix is merged

@romani romani closed this as completed Jul 26, 2020
Java 14 syntax features automation moved this from Review in progress to Done Jul 26, 2020
nrmancuso added a commit to nrmancuso/checkstyle that referenced this issue Aug 11, 2020
@nrmancuso
minor: remove already covered check PatternVariableName from pom.xml(c…
f117a14 
…heckstyle#8407)
@nrmancuso nrmancuso mentioned this issue Aug 11, 2020
Merged
pbludov pushed a commit that referenced this issue Aug 12, 2020
@nrmancuso @pbludov
minor: remove already covered check PatternVariableName from pom.xml(#…
5c1d654 
…8407)
shiliyu pushed a commit to shiliyu/checkstyle that referenced this issue Sep 1, 2020
@nrmancuso @shiliyu
minor: remove already covered check PatternVariableName from pom.xml(c…
63ec6fd 
…heckstyle#8407)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved new feature new module
Projects
No open projects
Java 14 syntax features
  
Done
Milestone
8.36
Development

No branches or pull requests
2 participants
@romani @nrmancuso