Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update AnnotationLocationCheckTest to use unique Input file in each test method #9437

Closed
romani opened this issue Mar 14, 2021 · 2 comments · Fixed by #9720
Closed

update AnnotationLocationCheckTest to use unique Input file in each test method #9437

romani opened this issue Mar 14, 2021 · 2 comments · Fixed by #9720
Labels
approved good second issue miscellaneous
Milestone
8.42

Comments

@romani
Copy link
Member

romani commented Mar 14, 2021 •
edited

AnnotationLocationCheckTest.java file reuse InputAnnotationLocationIncorrect.java in few different test method.
Expected: each test method in Test class use it own Input file and do not share it with any other test method.

more details - https://github.com/checkstyle/checkstyle/wiki/Good-practice-on-how-to-create-Input-files-for-tests
@romani
Copy link
Member Author

romani commented Mar 14, 2021

@SGanguly1999 , please help to fix this issue.

@SGanguly1999
Copy link
Contributor

Sure @romani

SGanguly1999 added a commit to SGanguly1999/checkstyle that referenced this issue Mar 25, 2021
@SGanguly1999
Issue checkstyle#9437: update AnnotationLocationCheckTest to use uniq…
584b4cd 
…ue Input file in each test method
@SGanguly1999 SGanguly1999 mentioned this issue Mar 25, 2021
Merged
SGanguly1999 added a commit to SGanguly1999/checkstyle that referenced this issue Mar 25, 2021
@SGanguly1999
Issue checkstyle#9437: update AnnotationLocationCheckTest to use uniq…
cd4646e 
…ue Input file in each test method
SGanguly1999 added a commit to SGanguly1999/checkstyle that referenced this issue Mar 25, 2021
@SGanguly1999
Issue checkstyle#9437: update AnnotationLocationCheckTest to use uniq…
ad0f5d6 
…ue Input file in each test method
SGanguly1999 added a commit to SGanguly1999/checkstyle that referenced this issue Mar 25, 2021
@SGanguly1999
Issue checkstyle#9437: update AnnotationLocationCheckTest to use uniq…
2ff1a3f 
…ue Input file in each test method
SGanguly1999 added a commit to SGanguly1999/checkstyle that referenced this issue Mar 25, 2021
@SGanguly1999
Issue checkstyle#9437: update AnnotationLocationCheckTest to use uniq…
92c27ca 
…ue Input file in each test method
SGanguly1999 added a commit to SGanguly1999/checkstyle that referenced this issue Mar 30, 2021
@SGanguly1999
Issue checkstyle#9437: update AnnotationLocationCheckTest to use uniq…
7aad1ed 
…ue Input file in each test method
SGanguly1999 added a commit to SGanguly1999/checkstyle that referenced this issue Mar 30, 2021
@SGanguly1999
Issue checkstyle#9437: update AnnotationLocationCheckTest to use uniq…
2887fba 
…ue Input file in each test method
SGanguly1999 added a commit to SGanguly1999/checkstyle that referenced this issue Apr 10, 2021
@SGanguly1999
Issue checkstyle#9437: update AnnotationLocationCheckTest to use uniq…
4c1f62a 
…ue Input file in each test method
romani pushed a commit that referenced this issue Apr 13, 2021
@SGanguly1999 @romani
Issue #9437: update AnnotationLocationCheckTest to use unique Input f…
25576c9 
…ile in each test method
@romani romani added this to the 8.42 milestone Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved good second issue miscellaneous
Projects
None yet
Milestone
8.42
Development

Successfully merging a pull request may close this issue.

Issue #9437: update AnnotationLocationCheckTest to use unique Input f… SGanguly1999/checkstyle
2 participants
@romani @SGanguly1999