Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update AbstractJavadocCheckTest to use unique Input file in each test method #9534

Closed
romani opened this issue Mar 15, 2021 · 5 comments · Fixed by #9992
Closed

update AbstractJavadocCheckTest to use unique Input file in each test method #9534

romani opened this issue Mar 15, 2021 · 5 comments · Fixed by #9992

Comments

@romani
Copy link
Member

romani commented Mar 15, 2021

AbstractJavadocCheckTest.java file reuse some Input files few time in few different test method.
Expected: each test method in Test class use it own Input file and do not share it with any other test method.

more details - https://github.com/checkstyle/checkstyle/wiki/Good-practice-on-how-to-create-Input-files-for-tests

@djzenma
Copy link
Contributor

djzenma commented Mar 18, 2021

I am on it

@MahmoudAbdelazim
Copy link
Contributor

I am on it

Are you still on it or I can work on it instead?

@romani
Copy link
Member Author

romani commented Mar 29, 2021

@MahmoudAbdelazim, you can create issue like this for yourself, just double check that issue for same test is not yet created.
Example of issue created by student #9741

@djzenma
Copy link
Contributor

djzenma commented Apr 3, 2021

I am on it

Are you still on it or I can work on it instead?

Ok, I leave it to you.

@MahmoudAbdelazim
Copy link
Contributor

I am on it

Are you still on it or I can work on it instead?

Ok, I leave it to you.

Thanks.

shashwatj07 added a commit to shashwatj07/checkstyle that referenced this issue May 8, 2021
shashwatj07 added a commit to shashwatj07/checkstyle that referenced this issue May 10, 2021
shashwatj07 added a commit to shashwatj07/checkstyle that referenced this issue May 11, 2021
shashwatj07 added a commit to shashwatj07/checkstyle that referenced this issue May 21, 2021
timurt pushed a commit that referenced this issue May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants