Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #8652: Checkstyle fails with unusual annotations #10435

Merged
merged 1 commit into from Aug 13, 2021
Merged

Issue #8652: Checkstyle fails with unusual annotations #10435

merged 1 commit into from Aug 13, 2021

Conversation

nrmancuso
Copy link
Member

@nrmancuso nrmancuso commented Jul 27, 2021 •
edited

Closes #8652.

Check Regression Reports

https://nmancus1.github.io/issue-8652_check_diff_reports_2021_08_11/diff_checks-nonjavadoc-error/index.html

https://nmancus1.github.io/issue-8652_check_diff_reports_2021_08_11/diff_checks-only-javadoc-error/index.html

  • All changes are in exception message line numbers only

https://nmancus1.github.io/issue-8652_check_diff_reports_2021_08_11/diff_part1/index.html

https://nmancus1.github.io/issue-8652_check_diff_reports_2021_08_11/diff_part2/index.html

https://nmancus1.github.io/issue-8652_check_diff_reports_2021_08_11/diff_part3/index.html

https://nmancus1.github.io/issue-8652_check_diff_reports_2021_08_11/diff_part4/index.html

https://nmancus1.github.io/issue-8652_check_diff_reports_2021_08_11/diff_part5/index.html

https://nmancus1.github.io/issue-8652_check_diff_reports_2021_08_11/diff_part6/index.html

https://nmancus1.github.io/issue-8652_check_diff_reports_2021_08_11/diff_sevntu-check-regression_part_1/index.html

https://nmancus1.github.io/issue-8652_check_diff_reports_2021_08_11/diff_sevntu-check-regression_part_2/index.html

  • All reports are clean

AST Regression Report

https://nmancus1.github.io/issue-8652_check_diff_reports_2021_08_11/diff-antlr/index.html

Clean

@nrmancuso nrmancuso marked this pull request as draft July 27, 2021 14:08
@nrmancuso nrmancuso force-pushed the issue-8652 branch 3 times, most recently from 55aa1b1 to 748b815 Compare August 2, 2021 11:56
@nrmancuso
Copy link
Member Author

nrmancuso commented Aug 2, 2021 •
edited

This PR must not be merged until:

1. #10280 is merged
2. New reports are generated from master branch -> still need AST regression report

@nrmancuso nrmancuso marked this pull request as ready for review August 2, 2021 13:54
@pbludov pbludov added the blocked label Aug 2, 2021
@romani
Copy link
Member

romani commented Aug 11, 2021

@nmancus1 , please fix conflict

@romani romani removed the blocked label Aug 11, 2021
@nrmancuso nrmancuso force-pushed the issue-8652 branch 4 times, most recently from eeecb38 to feda0da Compare August 11, 2021 04:20
@nrmancuso nrmancuso mentioned this pull request Aug 11, 2021
Merged
romani
romani approved these changes Aug 11, 2021
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge

@romani romani requested a review from pbludov August 11, 2021 21:55
@strkkk
Copy link
Member

strkkk commented Aug 12, 2021

@nmancus1 please resolve conflicts

@romani
Copy link
Member

romani commented Aug 12, 2021

Semaphore is restarted, it was stopped

@romani romani merged commit e41564b into checkstyle:master Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esilkensen esilkensen esilkensen approved these changes

@romani romani romani approved these changes

@pbludov pbludov pbludov approved these changes

@rnveach rnveach rnveach approved these changes

@strkkk strkkk strkkk approved these changes

Assignees

@pbludov pbludov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Checkstyle fails with unusual annotations
6 participants
@nrmancuso @romani @strkkk @esilkensen @pbludov @rnveach